1897830 - Still no window bar in Firefox applying a Firefox theme

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect, P3)

Description

[alenertz]

Attachment: Firedragon with window bar and mac buttons after applying firefox theme.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:125.0) Gecko/20100101 Firefox/125.0

Steps to reproduce:

Over a year ago I presented this bug already, but nothing happened since. Therefor I present here a few screenshots to show clearly what the issue is.
What I do: I use a Firefox theme to decorate the upper part of Firefox.

Actual results:

When I use and apply a Firefox theme such as Iridescence Dark or other, the window bar in Firefox disappears and Windows buttons are displayed instead of my Mac buttons (I use a MacOs Layout).

Expected results:

Applying a Firefox theme should keep the window bar and should display the chosen Mac buttons. This is the case e.g. in Firedragon and in the latest version of Linux Mint. See the screenshots below that I've attached here. It is only possible to present a screenshot, but I have 4 screenshots to show you all steps of this issue. So I'll make several bug reports that I deliver to you. You should make it possible in the future to post several screenshots for ONE bug report.
In the first screenshot below you see Firedragon with window bar, when I apply a Firefox theme with Mac buttons.

Comment 1

[Andrew McCreight [:mccr8]]

You can make multiple attachments for a single bug, after you file it.

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 7

[alenertz]

Hello Mr. McCreight

The problem is that Mozilla allows only one screenshot per bug report. So I made 3 further little bug reports that I named in the summary "II", "III" and "IV" and I posted 3 other screenshots to clarify the issue. But unfortunately these 3 screenshots have been deleted. If I click on "Details" no screenshot is displayed. At "bugs.kde.org", when I create a bug report I can add several screenshots to the bug report. Why not at bugzilla.mozilla.org. If that would have been possible, then I could have delivered 4 screenshots with one bug report. Make that possible, so that I can add 4 screenshots at one time. Are 1897831, 1897833 and 1897835 duplicates? These 3 "duplicates" refer by text to the screenshots 2-4 that I added there.
It is time that this bug will be fixed soon. It exists since version 112 of Firefox. I posted a bug report over a year ago and nothing happened to this date. I showed also in a screenshot that even Linux Mint Virginia still has the window bar, when I apply a Firefox theme. And Firedragon too.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

(In reply to alenertz from comment #7)

Hello Mr. McCreight

The problem is that Mozilla allows only one screenshot per bug report.

I think you can attach as many attachments as you wish by 'Attach new file' button (or do you miss that button due to missing BZ permissions?).

Also, moving to Firefox as it's not Widget/Toolkit issue.

Comment 9

[alenertz]

Attachment: Firefox with window bar and system theme showing mac buttons.png

Comment 10

[alenertz]

Attachment: Firefox without window bar after applying firefox theme showing Windows buttons.png

Comment 11

[alenertz]

Attachment: Window Bar Firefox 125.03 in Linux Mint with Firefox-theme.png

Comment 12

[alenertz]

Attachment: Firefox with window bar and system theme showing mac buttons.png

Comment 13

[alenertz]

Attachment: Firefox with window bar and system theme showing mac buttons.png

Comment 14

[Dão Gottwald [:dao]]

(In reply to alenertz from comment #0)

Steps to reproduce:

Over a year ago I presented this bug already, but nothing happened since. Therefor I present here a few screenshots to show clearly what the issue is.

Do you remember if this broke one day to the other a year ago, or whether it was broken way before that? A regression range might be helpful too.

Comment 15

[alenertz]

Attachment: Firefox shows window bar and system theme with mac buttons.png

Comment 16

[alenertz]

Good tip, Mr. Stransky and Mr. McCreight. When I made my first bug report a few days ago, there was no "Attach new file", as I remember. Fortunately It was my error. I have attached the other screenshots above.

Some short comments to these screenshots:

1. Firedragon with window bar and mac buttons after applying Firefox theme, here Iridescence Dark.

You see here that Firedragon has still the window bar with the mac buttons. And Firedragon had the window bar all the time in the past.

2. Firefox without window bar after applying firefox theme showing Windows buttons.

The system theme in Firefox displays and respects my mac buttons, until I switch to a Firefox theme.
But when I change the theme, a Firefox theme like Iridescence Dark, the window bar disappears displaying Windows buttons within the theme itself
instead of showing them normally in the window bar, when it is there.

3. Window Bar Firefox 125.03 in Linux Mint Virginia with Firefox theme

I was surprised, that Linux Mint 21.3 Virginia still has a window bar, when applying a Firefox theme. What is the reason?

I had also a fourth screenshot, but that screenshot could not be loaded. Reason unknown.

Comment 17

[alenertz]

Reply to Dao Gottwald

I'm using Linux and in Linux there is no mozregression, at least in my system that I use. What I can say, is, that this bug with the missing window bar, when applying a Firefox theme, goes right back to Firefox 112 and that is over one year ago. Prior to version 112 the window bar worked with a Firefox theme and after an update to version 112, the window bar disappeared and Windows buttons were displayed in the theme itself instead the mac buttons, that I normally use. In the actual version of Linux Mint Virginia and in Firedragon, which is a fork of Firefox, the window bar with the mac buttons is visible and works with the Firefox theme and the Firefox theme displays no Windows buttons, even no buttons at all in the theme itself, which should be the normal behavior. See my screenshots, that I attached to this bug report to visualize the issue.

Comment 18

[Alexandru Trif, Desktop Test Engineering [:atrif]]

I can reproduce the issue on Linux Mint 21.3 Cinnamon by installing the White Sur Dark Solid theme from the themes. After enabling any theme other than the System default one in Firefox, the custom macOS buttons are no longer displayed, and standard window buttons are shown instead.

However it seems that there are two behaviors here, so I have made two regression ranges:

• The first one is that the custom macOS buttons are shown with or without the title bar enabled when selecting a Firefox theme other than the System theme (e.g., Dark theme): pushlog link. This most likely changed with bug 1718846.
• The second behavior is that the macOS custom buttons are displayed only when the title bar is active inside the Customize menu and while the Dark theme is selected: pushlog link. Bug 1812289 may have changed the default state for the title bar, making this issue more visible.

Enabling the title bar from the Customize menu will display the macOS custom buttons on other Firefox themes besides the System's default one. If more information is needed please let me know. I don't know which issue is the regressor for sure.

Comment 19

[Emilio Cobos Álvarez [:emilio]]

Ok, so to be clear, the issue is that we're showing "windows buttons" (non-native buttons) on Linux with a custom theme?

If so, that's intended, see bug 1718846, and bug 1884452 where an opt-out was introduced (widget.gtk.non-native-titlebar-buttons.enabled).

Other than that, is there anything actionable here? We could expose this setting in the customize mode or something, but...

Comment 20

[Liz Henry (:lizzard) (relman/hg->git project)]

Since there is a workaround (setting widget.gtk.non-native-titlebar-buttons.enabled to true), setting this to wontfix for 128. Up to Emilio and Martin whether to wontfix the bug.

Comment 21

[alenertz]

I reported this bug, because the title bar/window bar was missing after applying a firefox theme. Now, yesterday, I found finally a solution to this issue after 18 months. It's incredibly simple and stupid. I'm wondering, why the guys from Firefox, who must know all settings that they created, didn't cleared this problem. One or two users shortly mentioned the solution, but prior to yesterday, I didn't understand it. Here ist the solution:
Go to Firefox Menu, choose "More Tools", then go to "Customize toolbar". Below on the left of the next page there's an option called "Titlebar" with a checkbox. Mark that checkbox and the titlebar reappears in Firefox. Click on "Done" below right and the setting is saved. Problem solved! Now I and every other user have the titlebar back with the mac buttons or windows buttons for others.

Comment 22

[Emilio Cobos Álvarez [:emilio]]

That is mentioned in comment 18 fwiw.

Ok this seems working as intended, all things considered.