189790 - voting info not displayed when editing/viewing a bug

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect, P3)

Description

[Jack Nerad]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.3a) Gecko/20021212

The voting information is not being displayed when editing or viewing a bug.  I
think this relates to the namespace used in edit.html.tmpl.

Reproducible: Always

Steps to Reproduce:
1. grab a new 2.17.3 from cvs
2. make sure voting stuff is set up in product and prefs.
3. 

Actual Results:  
I don't see the voting information line

Expected Results:  
It should show something like 

Votes:  0    Show votes for this bug    Vote for this bug

Comment 1

[Jack Nerad]

Attachment: A patch to edit.html.tmpl

This fixes the problem in my 2.17.3 installation

Comment 2

[Dave Miller [:justdave]]

I haven't seen Jack around much before, so I doubt if he has checking privs. 
Burnus, care to do the honors?

Comment 3

[Joel Peshkin]

Checked in for Burnus

Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
  edit.html.tmpl
new revision: 1.31; previous revision: 1.30
done                                          

Just a minor future reference thing...
When creating a patch, if you do the diff from the main bugzilla directory (the
same directory where checksetup lives), the the person applying the patch
doesn't have to know ahead of time what directory you patched.  The path will be
in the patch file.

Comment 4

[[e-mail]]

Was RCS file: /cvsroot /mozilla /webtools /bugzilla /template /en /default /bug
/edit.html.tmpl ,v not good enough for you?

Comment 5

[Dave Miller [:justdave]]

good enough for a human, but not for the 'patch' program.  patch reads either
the "diff" command line or the --- and +++ lines to determine what file to
patch.  So it then assumes you're patching a file in the current directory,
can't find it, and prompts the user for the file to patch.  Since it does
display the header to the user before prompting, you can just copy/paste, but
it's still annoying. :)  On a small patch like this it's not a big deal, but if
you're patching several files from the same diff file, it's a pain in the butt
to type every one :)

Comment 6

[Jack Nerad]

My bad.  Sorry about that.  I'll try to do it right in the future.  Thanks for
the correction.