1898204 - The cursor location doesn't update when clicking in the document

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Hubert Boma Manilla (:bomsy)]

In the bottom right corner of the editor footer, the cursor location info is not updated as it changes.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1898204 - [devtools] Show cursor location as document selection changes r=#devtools-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f90a3644c28
[devtools] Show cursor location as document selection changes r=devtools-reviewers,nchevobbe

Comment 3

[Iulian Moraru]

Backed out for causing dt failures on browser_dbg-search-file.js.

• Push with failures

• Failure log

• Backout link

[task 2024-08-20T08:14:58.824Z] 08:14:58     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-search-file.js | typing in the search input moves the cursor in the source content (line) - 
[task 2024-08-20T08:14:58.824Z] 08:14:58     INFO - Buffered messages finished
[task 2024-08-20T08:14:58.824Z] 08:14:58     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-search-file.js | typing in the search input moves the cursor in the source content (column) - Got 3, expected 6
[task 2024-08-20T08:14:58.824Z] 08:14:58     INFO - Stack trace:
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/browser-test.js:test_is:1625
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/head.js:assertCursorPosition:286
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-search-file.js:null:46
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - Check that pressing Enter navigates forward through the results
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - The Enter key is pressed
[task 2024-08-20T08:14:58.825Z] 08:14:58     INFO - The Enter key is pressed
[task 2024-08-20T08:14:58.836Z] 08:14:58     INFO - Check that pressing Shift+Enter navigates backward through the results
[task 2024-08-20T08:14:58.839Z] 08:14:58     INFO - The ShiftEnter key is pressed
[task 2024-08-20T08:14:58.903Z] 08:14:58     INFO - The ShiftEnter key is pressed
[task 2024-08-20T08:14:58.981Z] 08:14:58     INFO - Check that navigating backward goes to the last result when we were at the first one
[task 2024-08-20T08:14:58.982Z] 08:14:58     INFO - The ShiftEnter key is pressed
[task 2024-08-20T08:14:59.054Z] 08:14:59     INFO - Check that navigating forward goes to the first result when we were at the last one
[task 2024-08-20T08:14:59.056Z] 08:14:59     INFO - The Enter key is pressed
[task 2024-08-20T08:14:59.216Z] 08:14:59     INFO - Check that changing the search term works
[task 2024-08-20T08:14:59.217Z] 08:14:59     INFO - The fileSearch key is pressed
[task 2024-08-20T08:14:59.435Z] 08:14:59     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-search-file.js | The UI navigates to the new search results (line) - 
[task 2024-08-20T08:14:59.440Z] 08:14:59     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-08-20T08:14:59.440Z] 08:14:59     INFO - TEST-UNEXPECTED-FAIL | devtools/client/debugger/test/mochitest/browser_dbg-search-file.js | The UI navigates to the new search results (column) - Got 10, expected 16
[task 2024-08-20T08:14:59.441Z] 08:14:59     INFO - Stack trace:
[task 2024-08-20T08:14:59.441Z] 08:14:59     INFO - chrome://mochikit/content/browser-test.js:test_is:1625
[task 2024-08-20T08:14:59.441Z] 08:14:59     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/head.js:assertCursorPosition:286
[task 2024-08-20T08:14:59.442Z] 08:14:59     INFO - chrome://mochitests/content/browser/devtools/client/debugger/test/mochitest/browser_dbg-search-file.js:null:110
[task 2024-08-20T08:14:59.442Z] 08:14:59     INFO - chrome://mochikit/content/browser-test.js:handleTask:1145
[task 2024-08-20T08:14:59.442Z] 08:14:59     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1217
[task 2024-08-20T08:14:59.443Z] 08:14:59     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1358
[task 2024-08-20T08:14:59.443Z] 08:14:59     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1134
[task 2024-08-20T08:14:59.443Z] 08:14:59     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2024-08-20T08:15:00.019Z] 08:15:00     INFO - Waiting for state change: selected source
[task 2024-08-20T08:15:00.020Z] 08:15:00     INFO - --> The state was immediately correct (should rather do an immediate assertion?)
[task 2024-08-20T08:15:00.021Z] 08:15:00     INFO - TEST-PASS | devtools/client/debugger/test/mochitest/browser_dbg-search-file.js | Search field is still visible - 

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f07a8c9260eb
[devtools] Show cursor location as document selection changes r=devtools-reviewers,nchevobbe

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f07a8c9260eb