1898275 - New Tab Weather Widget: Add an impression and error event to telemetry

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement)

Description

[Maxx Crawford [:maxx]]

Add telemetry items for the following events:

• Impressions

Comment 1

[Maxx Crawford [:maxx]]

Attachment: Bug 1898275 - Add impression and error telemetry events to Weather feature r?#home-newtab-reviewers

Comment 2

[Scott [:thecount] Downe]

[Tracking Requested - why for this release]: This is needed for an experiment in 127.

This is mostly some boiler plate, jsx, some events, and bundled files changing.

This should be the last of our uplifts. fingers crossed

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e00d9ba1e266
Add impression and error telemetry events to Weather feature r=home-newtab-reviewers,thecount

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e00d9ba1e266

Comment 5

[Scott [:thecount] Downe]

Attachment: Bug 1898275 - Add impression and error telemetry events to Weather feature r?#home-newtab-reviewers

Original Revision: https://phabricator.services.mozilla.com/D211402

Comment 6

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This is needed for an experiment in 127.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: yes
• Steps to reproduce for manual QE testing: Set browser.newtabpage.activity-stream.system.showWeather, browser.newtabpage.activity-stream.telemetry, , browser.newtabpage.ping.enabled, and browser.newtabpage.activity-stream.telemetry.ut.events to true. 2. Go to about:glean and setup glean to test newtab pings. 3. Load newtab and see the weather report and close the newtab, should trigger the impression, to see the error event, you need to ensure the internet is turned off before opening newtab and flipping the prefs (no internet triggers and error), but in order to actually send the telemetry report, you need to turn the internet back on wait a bit, then close the tab. Both should fire glean events for "weather_impression" and "weather_load_error"
• Risk associated with taking this patch: Low
• Explanation of risk level: This is mostly some boiler plate, jsx, some events, and bundled files changing. Everything is also behind a pref.
• String changes made/needed: None
• Is Android affected?: no

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2558cf350e1e

Comment 8

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement using Firefox Beta 127.0b7 (Build ID: 20240526171419) downloaded from Treeherder and I can confirm that the "weather_load_error" event is sent to Glean when the Weather information is not available and "weather_impression" event is sent to Glean when opening a New Tab and the Weather widget is displayed on the page.

Comment 9

[Alice Varro [avarro], Ecosystem QA]

I have verified this enhancement using Firefox Nightly 128.0a1 (Build ID: 20240607090815) and I can confirm that the "weather_load_error" event is sent to Glean when the Weather information is not available and "weather_impression" event is sent to Glean when opening a New Tab and the Weather widget is displayed on the page.