1898353 - [wpt-sync] Sync PR 46441 - [WebDriver BiDi] Fix test for window.prompt opened

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46441 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46441
Details from upstream follow.

Nikolay Vitkov <[e-mail]> wrote:

[WebDriver BiDi] Fix test for window.prompt opened

In the HTML IDL - https://html.spec.whatwg.org/#the-window-object the function is defined as:
prompt(optional DOMString message = "", optional DOMString default = "");
This means that if no value is passed it get empty string.
I also observed that all values passed to the second parameter get toString(ed) (I think this is the algorithm that does it https://webidl.spec.whatwg.org/#js-DOMString),
Verified this behavior for Chrome, Firefox and Safari.

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ace089517d638cf875fce42fe50f0f6d0482787

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
PASS : 7
FAIL : 3

Chrome

OK : 1
PASS : 7
FAIL : 3

Safari

OK : 1
ERROR: 10

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /webdriver/tests/bidi/browsing_context/user_prompt_opened/user_prompt_opened.py [wpt.fyi]
  • test_prompt_type[prompt]: FAIL (Chrome: FAIL, Safari: ERROR)
  • test_prompt_default_value[undefined]: FAIL (Chrome: FAIL, Safari: ERROR)
  • test_prompt_default_value[empty string]: FAIL (Chrome: FAIL, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5582e885b91d
[wpt PR 46441] - [WebDriver BiDi] Fix test for window.prompt opened, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a73ef30d5b5b
[wpt PR 46441] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/5582e885b91d
https://hg.mozilla.org/mozilla-central/rev/a73ef30d5b5b