Closed Bug 1898371 Opened 2 years ago Closed 2 months ago

Avoid using HomeActivity directly

Categories

(Firefox for Android :: Experimentation and Telemetry, task)

All
Android
task

Tracking

()

RESOLVED FIXED

People

(Reporter: Gela, Unassigned)

Details

We want to avoid using HomeActivity directly if possible and instead just pass a closure to prevent bringing the entire HomeActivity to the class. This pattern needs to be cleaned up in MicrosurveyMessageController.kt and DefaultMessageController.kt. For example:

class MicrosurveyMessageController(
    private val appStore: AppStore,
    private val homeActivity: HomeActivity,
) : MessageController {
//...
}

Should be changed to

class MicrosurveyMessageController(
    private val appStore: AppStore,
    private val navigateToHome: () -> Unit
) : MessageController {
    //...
}
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.