Closed Bug 1898428 Opened 1 year ago Closed 1 year ago

The new crash reporter client is sending malformed legacy telemetry crash pings

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
128 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox126 + fixed
firefox127 + fixed
firefox128 + fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Bug 1898428 - Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
dmeehan
: approval-mozilla-release+
Details | Review

At the top level, the creationDate and clientId fields are mistakenly serialized as creation_data and client_id. The rest of the ping is fine.

Blocks: 1898073

This is quite odd, we do flag those fields as camelCase (see here), did we hit a bug in serde or did we do it wrong?

Ah yes, a silly oversight on our part. We applied the rename_all = "camelCase" attribute to the enum itself, not to the variant which contains the fields.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1759175

status-firefox-esr115: --- → unaffected

:gsvelto the Fx126 dot release is scheduled for next week.
The deadline for uplifts is eod tomorrow (Friday 2024-05-24)
I know this patch is still in review, but mentioning now if we should try include this. If it's not risky?

Flags: needinfo?(gsvelto)

Yes we should, as not having it blinds us to the main process crash rate (at least when looking at legacy telemetry). I'm confident I'll get the review and land the patch tonight.

Flags: needinfo?(gsvelto)

Thanks, please add the beta and release uplift request when you land it on autoland.
Relman can take it after it hits central

Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6bb885690e98 Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright

Backed out for causing crashreporter bustage.

[task 2024-05-23T16:43:25.371Z] 16:43:25     INFO -  ---- test::ping_and_event_files stdout ----
[task 2024-05-23T16:43:25.371Z] 16:43:25     INFO -  thread 'test::ping_and_event_files' panicked at toolkit/crashreporter/client/app/src/std/fs.rs:262:9:
[task 2024-05-23T16:43:25.371Z] 16:43:25     INFO -  assertion `left == right` failed: file content mismatch: ping_dir/00000000-0000-0000-0000-000000000000.json
[task 2024-05-23T16:43:25.372Z] 16:43:25     INFO -    left: "{\"type\":\"Crash\",\"id\":\"00000000-0000-0000-0000-000000000000\",\"version\":4,\"creationDate\":\"2004-11-09T12:34:56Z\",\"clientId\":\"telemetry_client\",\"payload\":{\"sessionId\":\"telemetry_session\",\"version\":1,\"crashDate\":\"2004-11-09\",\"crashTime\":\"2004-11-09T12:34:56Z\",\"hasCrashEnvironment\":true,\"crashId\":\"minidump\",\"minidumpSha256Hash\":\"9f64a747e1b97f131fabb6b447296c9b6f0201e79fb3c5356e6c77e89b6a806a\",\"processType\":\"main\",\"stackTraces\":{\"status\":\"OK\"},\"metadata\":{\"BuildID\":\"1234\",\"ProductName\":\"Bar\",\"ReleaseChannel\":\"release\"}},\"application\":{\"vendor\":\"FooCorp\",\"name\":\"Bar\",\"buildId\":\"1234\",\"displayVersion\":\"\",\"platformVersion\":\"\",\"version\":\"100.0\",\"channel\":\"release\"}}"
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -   right: "{\"type\":\"crash\",\"id\":\"00000000-0000-0000-0000-000000000000\",\"version\":4,\"creation_date\":\"2004-11-09T12:34:56Z\",\"client_id\":\"telemetry_client\",\"payload\":{\"sessionId\":\"telemetry_session\",\"version\":1,\"crashDate\":\"2004-11-09\",\"crashTime\":\"2004-11-09T12:34:56Z\",\"hasCrashEnvironment\":true,\"crashId\":\"minidump\",\"minidumpSha256Hash\":\"9f64a747e1b97f131fabb6b447296c9b6f0201e79fb3c5356e6c77e89b6a806a\",\"processType\":\"main\",\"stackTraces\":{\"status\":\"OK\"},\"metadata\":{\"BuildID\":\"1234\",\"ProductName\":\"Bar\",\"ReleaseChannel\":\"release\"}},\"application\":{\"vendor\":\"FooCorp\",\"name\":\"Bar\",\"buildId\":\"1234\",\"displayVersion\":\"\",\"platformVersion\":\"\",\"version\":\"100.0\",\"channel\":\"release\"}}"
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -  stack backtrace:
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -     0:     0x55e750044842 - std::backtrace_rs::backtrace::libunwind::trace::he4ee80166a02c846
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/../../backtrace/src/backtrace/libunwind.rs:105:5
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -     1:     0x55e750044842 - std::backtrace_rs::backtrace::trace_unsynchronized::h476faccf57e88641
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
[task 2024-05-23T16:43:25.373Z] 16:43:25     INFO -     2:     0x55e750044842 - std::sys_common::backtrace::_print_fmt::h430c922a77e7a59c
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:68:5
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -     3:     0x55e750044842 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hffecb437d922f988
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:44:22
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -     4:     0x55e7500729bc - core::fmt::rt::Argument::fmt::hf3df69369399bfa9
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/fmt/rt.rs:142:9
[task 2024-05-23T16:43:25.374Z] 16:43:25     INFO -     5:     0x55e7500729bc - core::fmt::write::hd9a8d7d029f9ea1a
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/fmt/mod.rs:1153:17
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -     6:     0x55e7500406cf - std::io::Write::write_fmt::ha6d88a9c0665f620
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/io/mod.rs:1843:15
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -     7:     0x55e750044614 - std::sys_common::backtrace::_print::hd2df4a083f6e69b8
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:47:5
[task 2024-05-23T16:43:25.375Z] 16:43:25     INFO -     8:     0x55e750044614 - std::sys_common::backtrace::print::he907f6ad7eee41cb
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:34:9
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -     9:     0x55e7500462cb - std::panicking::default_hook::{{closure}}::h3926193b61c9ca9b
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -    10:     0x55e750045fa7 - std::panicking::default_hook::h25ba2457dea68e65
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:289:9
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -    11:     0x55e74ff3bdc7 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h9bbd97bbd18d2a66
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/alloc/src/boxed.rs:2034:9
[task 2024-05-23T16:43:25.376Z] 16:43:25     INFO -    12:     0x55e74ff3bdc7 - test::test_main::{{closure}}::hf7bf1de88733e536
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:138:21
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -    13:     0x55e750046970 - <alloc::boxed::Box<F,A> as core::ops::function::Fn<Args>>::call::h022ca2c0d8c21c9e
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/alloc/src/boxed.rs:2034:9
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -    14:     0x55e750046970 - std::panicking::rust_panic_with_hook::h0ad14d90dcf5224f
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:783:13
[task 2024-05-23T16:43:25.377Z] 16:43:25     INFO -    15:     0x55e7500466b2 - std::panicking::begin_panic_handler::{{closure}}::h4a1838a06f542647
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:657:13
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -    16:     0x55e750044d16 - std::sys_common::backtrace::__rust_end_short_backtrace::h77cc4dc3567ca904
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:171:18
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -    17:     0x55e7500463e4 - rust_begin_unwind
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:645:5
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -    18:     0x55e7500701b5 - core::panicking::panic_fmt::h940d4fd01a4b4fd1
[task 2024-05-23T16:43:25.378Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:72:14
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -    19:     0x55e75007077f - core::panicking::assert_failed_inner::h3fa4c4749ee29c1d
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:338:23
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -    20:     0x55e74fe89658 - core::panicking::assert_failed::h2c6f2b7b9d272b09
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panicking.rs:298:5
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -    21:     0x55e74feed7a2 - crashreporter::std::fs::AssertFiles::check::h3cbf37244cabe476
[task 2024-05-23T16:43:25.379Z] 16:43:25     INFO -                                 at /builds/worker/checkouts/gecko/toolkit/crashreporter/client/app/src/std/fs.rs:262:9
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -    22:     0x55e74fef92dd - crashreporter::test::AssertFiles::ping::hfcc50632c8e4e2cb
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -                                 at /builds/worker/checkouts/gecko/toolkit/crashreporter/client/app/src/test.rs:308:9
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -    23:     0x55e74fe65d91 - crashreporter::test::ping_and_event_files::h38ae2b9836a37da8
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -                                 at /builds/worker/checkouts/gecko/toolkit/crashreporter/client/app/src/test.rs:646:5
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -    24:     0x55e74fe65d91 - crashreporter::test::ping_and_event_files::{{closure}}::h5f4e45e8d32b6162
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -                                 at /builds/worker/checkouts/gecko/toolkit/crashreporter/client/app/src/test.rs:631:26
[task 2024-05-23T16:43:25.380Z] 16:43:25     INFO -    25:     0x55e74fe65d91 - core::ops::function::FnOnce::call_once::h61950976fc01eeea
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -    26:     0x55e74ff409ff - core::ops::function::FnOnce::call_once::hdf5ca86569853e72
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -    27:     0x55e74ff409ff - test::__rust_begin_short_backtrace::hd4329dc6408133c8
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:621:18
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -    28:     0x55e74ff40083 - test::run_test_in_process::{{closure}}::h28125576fa02ab1b
[task 2024-05-23T16:43:25.381Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:644:60
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -    29:     0x55e74ff40083 - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::h263d7f9b738b9dba
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panic/unwind_safe.rs:272:9
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -    30:     0x55e74ff40083 - std::panicking::try::do_call::h07c639bca005fe67
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -    31:     0x55e74ff40083 - std::panicking::try::h58a07e442d3bdb92
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
[task 2024-05-23T16:43:25.382Z] 16:43:25     INFO -    32:     0x55e74ff40083 - std::panic::catch_unwind::h755d3ddccf2ee291
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -    33:     0x55e74ff40083 - test::run_test_in_process::h1afe055b8c5de7fa
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:644:27
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -    34:     0x55e74ff40083 - test::run_test::{{closure}}::h3810503c3fff9a00
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:567:43
[task 2024-05-23T16:43:25.383Z] 16:43:25     INFO -    35:     0x55e74ff07a63 - test::run_test::{{closure}}::he05fab8f6f4e5a70
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/test/src/lib.rs:595:41
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -    36:     0x55e74ff07a63 - std::sys_common::backtrace::__rust_begin_short_backtrace::he823da8fbe6df054
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys_common/backtrace.rs:155:18
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -    37:     0x55e74ff0c5cf - std::thread::Builder::spawn_unchecked_::{{closure}}::{{closure}}::h4ec5c7fc245f87d0
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/thread/mod.rs:528:17
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -    38:     0x55e74ff0c5cf - <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once::hc69a28560447662e
[task 2024-05-23T16:43:25.384Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/panic/unwind_safe.rs:272:9
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -    39:     0x55e74ff0c5cf - std::panicking::try::do_call::hf528d3cff240a786
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:552:40
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -    40:     0x55e74ff0c5cf - std::panicking::try::hb11bf079f9b1f405
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panicking.rs:516:19
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -    41:     0x55e74ff0c5cf - std::panic::catch_unwind::hcee8d50a8dc1d323
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/panic.rs:146:14
[task 2024-05-23T16:43:25.385Z] 16:43:25     INFO -    42:     0x55e74ff0c5cf - std::thread::Builder::spawn_unchecked_::{{closure}}::hb48d60f284150728
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/thread/mod.rs:527:30
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -    43:     0x55e74ff0c5cf - core::ops::function::FnOnce::call_once{{vtable.shim}}::h04ac49919f9d987a
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/core/src/ops/function.rs:250:5
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -    44:     0x55e75004b745 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h19b9e642d37e7272
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/alloc/src/boxed.rs:2020:9
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -    45:     0x55e75004b745 - <alloc::boxed::Box<F,A> as core::ops::function::FnOnce<Args>>::call_once::h97265befc434d3ae
[task 2024-05-23T16:43:25.386Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/alloc/src/boxed.rs:2020:9
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -    46:     0x55e75004b745 - std::sys::pal::unix::thread::Thread::new::thread_start::h420dad5cf01a9f35
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -                                 at /rustc/9b00956e56009bab2aa15d7bff10916599e3d6d6/library/std/src/sys/pal/unix/thread.rs:108:17
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -    47:     0x7fb5df633fd4 - <unknown>
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -    48:     0x7fb5df6b3820 - clone
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -    49:                0x0 - <unknown>
[task 2024-05-23T16:43:25.387Z] 16:43:25     INFO -  ---- test::pingsender_failure stdout ----
Flags: needinfo?(gsvelto)

I forgot to update the test data which contained the wrong fields 🤦

Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/387dd433d87b Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright

https://hg.mozilla.org/mozilla-central/rev/387dd433d87b

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox128: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 128 Branch

Comment on attachment 9403430 [details]
Bug 1898428 - Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright

Beta/Release Uplift Approval Request

  • User impact if declined: None, but we won't be able to track Firefox crash volume via legacy telemetry
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This only changes the format of the legacy crash ping sent by the crash reporter client. Gecko code is unaffected, this has no practical effects unless Firefox crashes.
  • String changes made/needed: none
  • Is Android affected?: No
Attachment #9403430 - Flags: approval-mozilla-release?
Attachment #9403430 - Flags: approval-mozilla-beta?

Comment on attachment 9403430 [details]
Bug 1898428 - Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright

Approved for 127 beta 6, thanks.

Attachment #9403430 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment on attachment 9403430 [details]
Bug 1898428 - Fix the format of legacy crash pings sent by the crash reporter client r=KrisWright

Approved for 126.0.1

Attachment #9403430 - Flags: approval-mozilla-release? → approval-mozilla-release+

Note that the patch does not address the extra precision of the creationDate field (as mentioned in bug 1898073).

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: