1898444 - Stop automatically setting the default account to log in at start-up

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, task)

Description

[Geoff Lankow (:darktrojan)]

https://searchfox.org/comm-central/rev/7a60376027142f054bb02e5e63e95e36a71c3d6d/mail/base/content/messenger.js#743-749

AFAICT, what this code is for is to reset the default account's loginAtStartUp setting to true, once – the first time that loadStartFolder is called after there is a default account. The preference is set and the code never runs again.

This is probably after the user sets up the first account using the account set up tab. The loadStartFolder preference is almost certainly already true.

However, there is another case where this code might run, and that's if an account is set up externally before Thunderbird starts. For example, in an automated test. In this case, if the preference is false it's probably explicitly false for a good reason. For example, in an automated test. Setting it to true only confuses the issue and the fact that this is a one-off change makes it more confusing.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1898444 - Stop automatically setting the default account to log in at start-up. r=#thunderbird-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/08dea595c755
Stop automatically setting the default account to log in at start-up. r=mkmelin