189853 - Menubar sometimes eats mouse clicks

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Warner Young]

Now that the fix for bug 179567 is checked in, I've noticed that clicking on the
menubar sometimes does nothing, and it takes a second click to get a menu top
drop down.  Unfortunately, I haven't figured out a 100% reliable way to
reproduce this yet, but the following may work:

Steps to reproduce:
1. Click on menubar (for example, on Bookmarks).
2. Bookmarks menu drops down.
3. Click on the browser's title bar to dismiss menu.
4. Bookmarks menu is dismissed correctly.
5. Click on Bookmarks again.

Actual results:
Bookmarks menu does not drop down, and it takes a second click to trigger it.

Expected results:
Bookmarks menu should drop down with the first click.

Build 2003012005, Win98.

Comment 1

[Warner Young]

CC'ing aaronl.  Hope I'm not overstepping my bounds, but this seems to have
started when bug 179567 was fixed, so I suspect it's a side-effect of that fix.

Comment 2

[Aaron Leventhal]

See if you can get a 100% reliable testcase.

Comment 3

[Warner Young]

Aaron, it turns out I can reproduce this 100% using the initial steps I gave.

Comment 4

[Aaron Leventhal]

Are you moving your mouse even a hair between clicks?
Or do 3 quick clicks in the exact same place not pull down the bookmarks menu.

Comment 5

[Aaron Leventhal]

I still cannot repro this at all.

Comment 6

[Warner Young]

Aaron, I am moving the mouse between clicks.  The steps I gave pretty much
require the mouse to move: click on Bookmarks menu (not the Personal toolbar,
but the main menubar), move mouse to the window's titlebar and click to dismiss
Bookmarks menu, then move back to Bookmarks in main menubar and click.

Clicking 3 times over the same menubar item seems to work: 1st click drops down
a menu, 2nd click dismisses, and 3rd click drops the menu again.

Comment 7

[Aaron Leventhal]

Aha, my fault for misreading your steps.

Comment 8

[Aaron Leventhal]

Attachment: Also call ClearRecentlyRolledUp() whenever new menu item is highlighted. That way it won't block the next click.

Comment 9

[Aaron Leventhal]

Comment on attachment 112329 [details] [diff] [review]
Also call ClearRecentlyRolledUp() whenever new menu item is highlighted. That way it won't block the next click.

This is a 1 line patch that just makes sure that clicks don't get accidentally
blocked.

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 112329 [details] [diff] [review]
Also call ClearRecentlyRolledUp() whenever new menu item is highlighted. That way it won't block the next click.

a=asa (on behalf of drivers) for checkin to 1.3beta.

Comment 11

[Aaron Leventhal]

checked in

Comment 12

[Jason Bassford]

*** Bug 190209 has been marked as a duplicate of this bug. ***

Comment 13

[Ian Nartowicz]

*** Bug 190998 has been marked as a duplicate of this bug. ***

Comment 14

[Warner Young]

*** Bug 194450 has been marked as a duplicate of this bug. ***