1898593 - Places Window ("All Downloads") initially shows up white even when using the dark theme, causing a flashing appearance

Status: RESOLVED DUPLICATE of bug 1824053

(Firefox :: Bookmarks & History, defect)

Description

[mkshadoff]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:126.0) Gecko/20100101 Firefox/126.0

Steps to reproduce:

1. Open Firefox
2. Open All Downloads

This only happens the first time it is opened after opening Firefox

Actual results:

Loading window was white

Expected results:

Loading window should be dark in dark mode

Comment 1

[mkshadoff]

Attachment: Bug (flash warning)).mp4

This is a video of the bug taken on my phone. A screen recorder seems to cause sufficient lag such that this no longer happens

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Downloads Panel' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Marco Bonardo [:mak]]

Moving to Bookmarks & History, as this is not specific to downloads, it's the window background that flashes white, so it should do it also for bookmarks, history and so on.

Emilio, is there anything special we must set on the window to ensure the initial background is dark?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

I'd try to move around the UpdateDarkModeToolbar call here, maybe right before nsWindow::Show(). But other than that, no better ideas off-hand.

Comment 5

[Daniel Bodea [:danibodea]]

I am having a hard time trying to reproduce it on my system. I would like to ask you some questions that might help us address your issue:

1. Does it reproduce ONCE every time you reopen the browser? Or does it only reproduce sometimes?
2. What is the version of Firefox that you can consistently reproduce it on?
3. Does it still reproduce consistently on the latest update of the application?
4. What model of Graphic card are you using?
5. Which theme do you have set in the browser? Is is "Dark" or is it "System theme - auto" with Dark Theme set in Windows?

Thank you very much!

Comment 6

[mkshadoff]

(In reply to Daniel Bodea [:danibodea] from comment #5)

I am having a hard time trying to reproduce it on my system. I would like to ask you some questions that might help us address your issue:

1. Does it reproduce ONCE every time you reopen the browser? Or does it only reproduce sometimes?
2. What is the version of Firefox that you can consistently reproduce it on?
3. Does it still reproduce consistently on the latest update of the application?
4. What model of Graphic card are you using?
5. Which theme do you have set in the browser? Is is "Dark" or is it "System theme - auto" with Dark Theme set in Windows?

Thank you very much!

It happens multiple times after opening the browser, seemingly every time

It happens on following system theme and dark mode

It reproduces consistently on 126.0.1 which is the most recent version

Graphics card is 3070 rtx

I dont know how much help this is but i recall there being a bug about how popups flash white in firefox and i think this may be a duplicate i will try to find that bug

Comment 7

[mkshadoff]

(In reply to mkshadoff from comment #6)

(In reply to Daniel Bodea [:danibodea] from comment #5)

I am having a hard time trying to reproduce it on my system. I would like to ask you some questions that might help us address your issue:

1. Does it reproduce ONCE every time you reopen the browser? Or does it only reproduce sometimes?
2. What is the version of Firefox that you can consistently reproduce it on?
3. Does it still reproduce consistently on the latest update of the application?
4. What model of Graphic card are you using?
5. Which theme do you have set in the browser? Is is "Dark" or is it "System theme - auto" with Dark Theme set in Windows?

Thank you very much!

It happens multiple times after opening the browser, seemingly every time

It happens on following system theme and dark mode

It reproduces consistently on 126.0.1 which is the most recent version

Graphics card is 3070 rtx

I dont know how much help this is but i recall there being a bug about how popups flash white in firefox and i think this may be a duplicate i will try to find that bug

Bug 1824053 is a bug about firefox popups initially appearing white i think this may be a duplicate

Comment 8

[Daniel Bodea [:danibodea]]

It would appear that the skeleton-UI is showing before the correct UI is painted. I could not reproduce it consistently on any of my systems, but it did very rarely reproduce, unable to determine an exact cause. That's why I have reason to believe that I suspect this bug to be somewhat specific to high-end systems, painting the skeleton-UI much faster than on lower-end systems.

I will be closing it as a duplicate of bug 1824053. Thank you for your report!

Comment 9

[:Gijs (he/him)]

(In reply to Daniel Bodea [:danibodea] from comment #8)

It would appear that the skeleton-UI is showing before the correct UI is painted. I could not reproduce it consistently on any of my systems, but it did very rarely reproduce, unable to determine an exact cause. That's why I have reason to believe that I suspect this bug to be somewhat specific to high-end systems, painting the skeleton-UI much faster than on lower-end systems.

I will be closing it as a duplicate of bug 1824053. Thank you for your report!

*** This bug has been marked as a duplicate of bug 1824053 ***

Skeleton UI shouldn't be used for places windows, I think? Maybe Ray can clarify.

Comment 10

[Ray Kraesig [:rkraesig]]

(In reply to Daniel Bodea [:danibodea] from comment #8)

It would appear that the skeleton-UI is showing before the correct UI is painted.

Nit: the "skeleton UI" only exists on the very first Firefox window, created before Firefox has been completely initialized, which isn't the case here. The skeleton UI is also dark-themed if appropriate; even if it were being shown here, it wouldn't be the problem.

That said, closing as duplicate for bug 1824053 is probably correct. (Though of course there's no way to know for sure until the fix ships.)