1898601 - layout/media should probably move somewhere else / be deleted.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

I don't understand what it does (it's almost empty), but if it's needed it should probably live somewhere else (like media/ or so)?

Paul, do you have context about this directory?

Comment 1

[Daniel Holbert [:dholbert]]

It only has two moz.build files:

https://searchfox.org/mozilla-central/source/layout/media/moz.build
https://searchfox.org/mozilla-central/source/layout/media/webrtc/moz.build

I think this directory existed for arcane linking reasons back when we had libgklayout.so and such, which meant certain layout-adjacent things needed to be built as part of the layout directory?

There's some references where it was a bit bigger here, for example:
https://hg.mozilla.org/mozilla-central/rev/32e001c1351b8f84e72945241adf453008e50c8a

Anyway -- I suspect it doesn't need to exist anymore, given that it's just moz.build files at this point and we don't ever have libgklayout as a distinct library these days, which means I don't think there's any special reason that things need to be compiled as part of layout/

Comment 2

[Jim Mathies [:jimm]]

Remove it and see what breaks? :)

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1898601 - Remove fake webrtc/gkmedias libs. r=glandium!,#media-playback-reviewers

The tests referenced by gkmedias were ported to gtest. The relevant
build file was removed bug 1357328.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1898601 - Automatic libwebrtc moz.build regeneration. r=#webrtc-reviewers!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b167bbce57c
Remove fake webrtc/gkmedias libs. r=glandium,media-playback-reviewers,webrtc-reviewers,cubeb-reviewers,pehrsons,padenot
https://hg.mozilla.org/integration/autoland/rev/62f3712eb532
Automatic libwebrtc moz.build regeneration. r=webrtc-reviewers,pehrsons

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6b167bbce57c
https://hg.mozilla.org/mozilla-central/rev/62f3712eb532