1898650 - Re-remove sync wait in compositor thread of main thread canvas on Nightly

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Sotaro Ikeda [:sotaro]]

With Bug 1898436, it seems ok to re-remove sync wait in compositor thread of main thread canvas on Nightly.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1898650 - Re-remove sync wait in compositor thread of main thread canvas on Nightly

Comment 2

[Mayank Bansal]

I tested the try build from bug 1898436.
On https://codepen.io/tsuhre/pen/RwGGrGx, if i slowly keep on resizing the code-pane (such that hte demo-pane resizes), intermittently the demo-pane gets stuck at some state.
https://share.firefox.dev/4bwrbev (with logging) / https://share.firefox.dev/44TPikG / https://share.firefox.dev/4bRBIkg

Comment 3

[Sotaro Ikeda [:sotaro]]

Thank you for the checking! I am going to check it.

Comment 4

[Sotaro Ikeda [:sotaro]]

I confirmed the problem with the following prefs.

• gfx.direct2d.disabled = true
• gfx.canvas.accelerated = true
• gfx.canvas.remote.worker-threads = 0

When the problem happened, somehow canvas rendering was stopped.

Comment 5

[Sotaro Ikeda [:sotaro]]

There was a case that remote texture owner was destroyed even though its life time was extended by RemoteTextureTxnScheduler and calling RemoteTextureTxnScheduler::NotifyTxn() of main thread canvas is deferred to WebRenderAPI for waiting RemoteTextureOwner at WebRenderAPI by Bug 1863257.

Comment 6

[Mayank Bansal]

Another testcase where this repros easily is : https://codepen.io/Mertl/pen/vYPXMao
I can repro with both gpu-canvas and d2d-canvas here.

Profiles with logging:
gpu-canvas: https://share.firefox.dev/4dRhk4r
d2d-canvas: https://share.firefox.dev/44SDJKJ

Comment 7

[Sotaro Ikeda [:sotaro]]

(In reply to Mayank Bansal from comment #6)

Another testcase where this repros easily is : https://codepen.io/Mertl/pen/vYPXMao
I can repro with both gpu-canvas and d2d-canvas here.

It also seemed to be addressed by Bug 1899096 for me.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/115014551118
Re-remove sync wait in compositor thread of main thread canvas on Nightly r=gfx-reviewers,lsalzman

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/115014551118