189897 - Download starts with Download Error, then Cancel Button disabled

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, defect, P1)

Description

[Hermann Schwab]

User-Agent:       Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030120
Build Identifier: Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.3b) Gecko/20030120

In the last days downloads often start with a box "Download Error",
but Downloadmanager shows progress, and the files are saved to disk.
After Download Error is shown, Cancel-Button is disabled, so there is no way to
stop a download of maybe a 700 MB iso.
If Download Error wasn´t shown, Cancel Button is working.

I don´t believe this is a dup of bug 159186 Cannot cancel download,
because there the same file had been downloaded twice to cause the errror.

Here the error is caused by networking, and leads to a wrong state in
downloadmanager: download is working, but cancel disabled, because download not
active is assumed, I guess. 

I think this bug is visible now because of mozillas network problems.
It will still be there in the underlying logic, if the network errors are solved.

Besides, I had some problems removing (multiple) files from download manager.
When cursor was blue, it was working, when cursorline was grey, it didn´t work.
Maybe that was related to the state of cancel button.

Reproducible: Sometimes

Steps to Reproduce:
1.start download of a medium sized file
2.if download error pops up, acknowledge
3.try to cancel download with cancel button
Actual Results:  
if download started normally, Cancel works.
if download started with ErrorBox, Cancel Button grayed out, no way to stop
download.

Expected Results:  
Cancel ;-)

Comment 1

[kurros (Wade Majors)]

Dupe of bug 189689?

Comment 2

[Hermann Schwab]

Dupe of bug 189689? 
That bug is about a corrupt display of content, and this bug is about corrupt
display of metadata, but the download is also often corrupt, I forgot to mention,
so the underlying mechanism will be the same which caused 189689.
But I assume that fixing bug 189689 doesn´t fix this error,
this error will only be seen less often.
I had to install 20030116 for downloading todays nightlies without getting some
CRCs when installing.

Comment 3

[Boris Zbarsky [:bzbarsky]]

to darin

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

I can see this on Linux too. The OS should be All.

Comment 5

[Todd]

Hi All,

   I am getting the same error with 1.3.0.2003012008 on w2k-p, sp3.
I get an error message when I start to download, then download proceeds
with no cancel button up to about 98% and stops.  It is like the first 2%
does something to cause the error and gets chucked away before the
download continues.
 
   I had to install 1.2.1, browser only, in a seperate directory to get
my downloads.  I used IE once too.  :-[

--Tony
[e-mail]

Comment 6

[Darin Fisher]

i've also seen this.  i'm thinking it is likely a dupe of bug 189689.  now that
that bug is fixed, we'll see if this problem continues.

Comment 7

[Darin Fisher]

Attachment: v1 patch

the problem here is that the webbrowserpersist is treating
nsISocketTransport::STATUS_WAITING_FOR as an error.  the fix is trivial.

Comment 8

[Darin Fisher]

*** Bug 190156 has been marked as a duplicate of this bug. ***

Comment 9

[Adam Lock]

Comment on attachment 112373 [details] [diff] [review]
v1 patch

r=adamlock

Comment 10

[Darin Fisher]

Comment on attachment 112373 [details] [diff] [review]
v1 patch

requesting drivers approval for 1.3b: this is a low risk, trivial fix for a
nasty downloader regression.

Comment 11

[Darin Fisher]

fixed-on-trunk

Comment 12

[Chris Petersen]

Verified in the Win32 2003-01-25-08 trunk under Windows XP.