1899143 - [wpt-sync] Sync PR 46496 - [text-box-trim] Support when the last line is empty

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46496 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46496
Details from upstream follow.

Koji Ishii <[e-mail]> wrote:

[text-box-trim] Support when the last line is empty

Normally, empty lines can exist only in an empty inline
formatting context. But there are some rare cases where empty
lines can exist in non-empty inline formatting context. When
such empty lines are at the end of the inline formatting
context, RelayoutForTextBoxTrimEnd() needs to let
InlineLayoutAlgorithm know whether the line is the last
non-empty line or not.

This patch adds ShouldForceTextBoxTrimEnd() to communicate
that information from BlockLayoutAlgorithm to
InlineLayoutAlgorithm.

Bug: 40254880
Change-Id: Ia440325c502db0dcc3c8f248cc3c7ec3588f7fd7
Reviewed-on: https://chromium-review.googlesource.com/5568835
WPT-Export-Revision: fb186852bd1488bfee5da80149f354888e4c62de

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=232f7305fc784384114dbb36d225b05047e55f18

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-inline/text-box-trim/text-box-trim-end-empty-line-001.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c18a5374b9ab
[wpt PR 46496] - [text-box-trim] Support when the last line is empty, a=testonly
https://hg.mozilla.org/integration/autoland/rev/81f47bddc4ca
[wpt PR 46496] - Update wpt metadata, a=testonly

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c18a5374b9ab
https://hg.mozilla.org/mozilla-central/rev/81f47bddc4ca