1899160 - Make it possible to allocate JSStrings with a refcounted StringBuffer in the shell

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Jan de Mooij [:jandem]]

Add support for allocating JS strings with refcounted buffers to the newString testing function.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: WIP: Bug 1899160 - WIP

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1899160 part 1 - Add support for allocating JS strings with a refcounted StringBuffer. r?sfink!

This adds initial support for JS strings that have a refcounted mozilla::StringBuffer
instead of a raw malloc buffer.

The newString testing function has two new options. This lets us allocate a new JS string
with a new buffer or a new JS string that reuses the underlying string buffer.

After this we can start using this to replace external strings. We can also allocate more JS
strings with StringBuffers instead of raw malloc buffers.

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1899160 part 2 - Fix string arena assertion for dependent strings backed by a StringBuffer. r?sfink!

We already avoid calling AssertJSStringBufferInCorrectArena when creating a JS string with
a StringBuffer, but we weren't handling this case when moving dependent strings.

This patch changes relocateNonInlineChars to relocateBaseAndChars so we can check
for this case there.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04287c05c925
part 1 - Add support for allocating JS strings with a refcounted StringBuffer. r=sfink
https://hg.mozilla.org/integration/autoland/rev/bac40907d2f0
part 2 - Fix string arena assertion for dependent strings backed by a StringBuffer. r=sfink

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/04287c05c925
https://hg.mozilla.org/mozilla-central/rev/bac40907d2f0