1899205 - Implement UiStore in lib-state

Status: RESOLVED FIXED

(Firefox for Android :: General, enhancement, P1)

Description

[Jonathan Almeida [:jonalmeida]]

With the RFC in bug 1877307 landed, we should now implement it.

Comment 1

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1899205 - Introduce UiStore to lib-state component r=#android-reviewers

We introduce a new UiStore that requires moving around some parts
of the original Store around, while keeping the surface area
identical to before so that we can swap between the different types.

Some noteworthy points and concepts introduced:

• A StoreDispatcher holds the CoroutineContext in which a Store has
  implemented.
• We move the assertOnThread out from the StoreThreadFactory so
  that we can now provide custom assertions based on the
  StoreDispatcher.
• Some of the new files introduced are from moving multiple classes
  out from one file so that they can be better referenced in those new
  cases mentioned above.

Comment 2

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1899205 - Introduce UiStore to lib-state component r=#android-reviewers

We introduce a new UiStore that requires moving around some parts
of the original Store around, while keeping the surface area
identical to before so that we can swap between the different types.

Some noteworthy points and concepts introduced:

• A StoreDispatcher holds the CoroutineContext in which a Store has
  implemented.
• We move the assertOnThread out from the StoreThreadFactory so
  that we can now provide custom assertions based on the
  StoreDispatcher.
• Some of the new files introduced are from moving multiple classes
  out from one file so that they can be better referenced in those new
  cases mentioned above.

Comment 3

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1899205 - Introduce UiStore to lib-state component r=#android-reviewers

We introduce a new UiStore that requires moving around some parts
of the original Store around, while keeping the surface area
identical to before so that we can swap between the different types.

Some noteworthy points and concepts introduced:

• A StoreDispatcher holds the CoroutineContext in which a Store has
  implemented.
• We move the assertOnThread out from the StoreThreadFactory so
  that we can now provide custom assertions based on the
  StoreDispatcher.
• Some of the new files introduced are from moving multiple classes
  out from one file so that they can be better referenced in those new
  cases mentioned above.

Comment 4

[Jonathan Almeida [:jonalmeida]]

Attachment: Bug 1899205 - Introduce UiStore to lib-state component r=#android-reviewers

We introduce a new UiStore that requires moving around some parts
of the original Store around, while keeping the surface area
identical to before so that we can swap between the different types.

Some noteworthy points and concepts introduced:

• A StoreDispatcher holds the CoroutineContext in which a Store has
  implemented.
• We move the assertOnThread out from the StoreThreadFactory so
  that we can now provide custom assertions based on the
  StoreDispatcher.
• Some of the new files introduced are from moving multiple classes
  out from one file so that they can be better referenced in those new
  cases mentioned above.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4b1db74dd63
Introduce UiStore to lib-state component r=android-reviewers,petru,matt-tighe,rsainani

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d4b1db74dd63