1899219 - Remove unused CompositorMap

Status: RESOLVED FIXED

(Core :: Graphics, task)

Description

[Sotaro Ikeda [:sotaro]]

CompositorMap is not used with WebRender.

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1899219 - Remove unused CompositorMap

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/daae8c59098a
Remove unused CompositorMap r=gfx-reviewers,lsalzman

Comment 3

[Iulian Moraru]

Backed out for causing build bustages on CompositorBridgeParent.cpp.

• Push with failures

• Failure log

• Backout link

[task 2024-05-28T04:43:53.450Z] 04:43:53     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/gfx/layers'
[task 2024-05-28T04:43:53.453Z] 04:43:53     INFO -  /builds/worker/fetches/sccache/sccache /builds/worker/fetches/clang/bin/clang++ -isysroot /builds/worker/fetches/MacOSX14.4.sdk -mmacosx-version-min=11.0 -stdlib=libc++ --target=aarch64-apple-darwin -o Unified_cpp_gfx_layers6.o -c  -I/builds/worker/workspace/obj-build/dist/stl_wrappers -fvisibility=hidden -fvisibility-inlines-hidden -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -ftrivial-auto-var-init=pattern -DDEBUG=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DMOZ_APP_VERSION=128.0a1 -DD3D_DEBUG_INFO -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -DSTATIC_EXPORTABLE_JS_API -I/builds/worker/checkouts/gecko/gfx/layers -I/builds/worker/workspace/obj-build/gfx/layers -I/builds/worker/workspace/obj-build/ipc/ipdl/_ipdlheaders -I/builds/worker/checkouts/gecko/ipc/chromium/src -I/builds/worker/checkouts/gecko/docshell/base -I/builds/worker/checkouts/gecko/dom/canvas -I/builds/worker/checkouts/gecko/gfx/cairo/cairo/src -I/builds/worker/checkouts/gecko/layout/base -I/builds/worker/checkouts/gecko/layout/generic -I/builds/worker/checkouts/gecko/media/libyuv/libyuv/include -I/builds/worker/checkouts/gecko/gfx/skia -I/builds/worker/checkouts/gecko/gfx/skia/skia -I/builds/worker/workspace/obj-build/dist/include -I/builds/worker/workspace/obj-build/dist/include/nspr -I/builds/worker/workspace/obj-build/dist/include/nss -DMOZILLA_CLIENT -include /builds/worker/workspace/obj-build/mozilla-config.h -fno-rtti -pthread -fno-sized-deallocation -fno-aligned-new -ffunction-sections -fdata-sections -fno-math-errno -fno-exceptions -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fPIC -gdwarf-4 -Xclang -load -Xclang /builds/worker/workspace/obj-build/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -Wall -Wbitfield-enum-conversion -Wempty-body -Wformat-type-confusion -Wignored-qualifiers -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtautological-constant-in-range-compare -Wtype-limits -Wno-error=tautological-type-limit-compare -Wunreachable-code -Wunreachable-code-return -Wunused-but-set-parameter -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wno-range-loop-analysis -Wenum-compare-conditional -Wenum-float-conversion -Wno-deprecated-anon-enum-enum-conversion -Wno-deprecated-enum-enum-conversion -Wno-deprecated-this-capture -Wcomma -Wimplicit-fallthrough -Wduplicate-method-arg -Wduplicate-method-match -Wmissing-method-return-type -Wobjc-signed-char-bool -Wsemicolon-before-method-body -Wsuper-class-method-mismatch -Wstring-conversion -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wno-error=atomic-alignment -Wno-error=deprecated-builtins -Wformat -Wformat-security -Wno-psabi -Wthread-safety -Werror=unguarded-availability-new -Wno-error=builtin-macro-redefined -Wno-vla-cxx-extension -Wno-unknown-warning-option -Werror=switch -fno-strict-aliasing -ffp-contract=off  -MD -MP -MF .deps/Unified_cpp_gfx_layers6.o.pp   Unified_cpp_gfx_layers6.cpp
[task 2024-05-28T04:43:53.453Z] 04:43:53     INFO -  In file included from Unified_cpp_gfx_layers6.cpp:56:
[task 2024-05-28T04:43:53.453Z] 04:43:53    ERROR -  /builds/worker/checkouts/gecko/gfx/layers/ipc/CompositorBridgeParent.cpp:117:13: error: unused function 'AssertIsInCompositorThread' [-Werror,-Wunused-function]
[task 2024-05-28T04:43:53.454Z] 04:43:53     INFO -    117 | static void AssertIsInCompositorThread() {
[task 2024-05-28T04:43:53.454Z] 04:43:53     INFO -        |             ^~~~~~~~~~~~~~~~~~~~~~~~~~
[task 2024-05-28T04:43:53.454Z] 04:43:53     INFO -  1 error generated.
[task 2024-05-28T04:43:53.454Z] 04:43:53    ERROR -  gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:688: Unified_cpp_gfx_layers6.o] Error 1
[task 2024-05-28T04:43:53.454Z] 04:43:53     INFO -  gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/gfx/layers'

Comment 4

[Sotaro Ikeda [:sotaro]]

Addressed build failure.
https://treeherder.mozilla.org/jobs?repo=try&revision=57201de488766601f998834bb2091eb983db73e9

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43603336d2a1
Remove unused CompositorMap r=gfx-reviewers,lsalzman

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/43603336d2a1