1899249 - O_LARGEFILE value mismatch on musl libc

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Patrycja Rosa [:ptrcnull] (she/her)]

With musl libc, fcntl.h contains the correct value of O_LARGEFILE, which may differ between architectures (e.g. powerpc has 020000, and aarch64 has 0400000, compared to usual 0100000); instead of hardcoding the value, a check for whether O_LARGEFILE is set to 0 (and if it's not, taking the actual value) would be more appropriate here.

Marking this as "Firefox 126", but the issue has been there since forever (at least Firefox 82.0.3).

Comment 1

[Patrycja Rosa [:ptrcnull] (she/her)]

Attachment: Bug 1899249 - Use actual O_LARGEFILE value whenever available. r=jld

Comment 2

[:gerard-majax]

thanks for fixing that!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e1bfbb5ee467
Use actual O_LARGEFILE value whenever available. r=gerard-majax

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e1bfbb5ee467