1899304 - Quickly clicking on another tab after closing a tab causes the tab to remain opened

Status: RESOLVED DUPLICATE of bug 1897803

(Firefox for Android :: Tabs, defect, P3)

Description

[Rummskartoffel]

Steps to reproduce:

1. Open at least two tabs.
2. Open the tab list.
3. Swipe to close one of the tabs.
4. Quickly tap on another tab to switch to it.
5. Once the tab list has closed, open it again.

Actual results:

The tab you tried to close is still open.

Expected results:

The tab you tried to close should have been closed.

I feel like this issue appeared within the last month (Nightly) or so, but I can't say for sure.

Comment 1

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

I was able to reproduce this on a Samsung S21 (Android 14) and Samsung A35 (Android 14). Please see recording for more details.

Comment 2

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

Attachment: Screen_recording_20240603_105626.mp4

Comment 3

[Nicholas Poon (redirect NI to [e-mail]) [:Nick]]

In TabListItem.kt, in TabListItem, there is a shouldClickListen parameter that can be toggled to true or false. In the onItemDismiss property in SwipeToDismissBox here, there is a call to onCloseClick. Before this call, we can set the shouldClickListen parameter to false. After this call, we can set the shouldClickListen parameter back to true and that should prevent the user from switching tabs while the close animation / process is occurring.

Comment 4

[Noah Bond [:007]]

Hey Rummskartoffel, thanks for filing this bug. This looks like a dupe of Bug 1897803, so I'm closing this one in favor of that.