toolkit/moz.configure: @depends function needs the same `when` as options it depends on
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
People
(Reporter: herrtimson, Unassigned)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
20.06 KB,
text/x-log
|
Details |
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/115.0
Steps to reproduce:
hey everyone, I downloaded the latest git sources and tried to compile them with clang-18, on linux amd64
Actual results:
configure fails with a skittish python error, it seems the latest changes in bug 1776255 are responsible:
0:00.81 checking for target system type... x86_64-pc-linux-gnu
0:01.13 checking whether cross compiling... no
0:01.19 Traceback (most recent call last):
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/configure.py", line 351, in <module>
0:01.19 sys.exit(main(sys.argv))
0:01.19 ^^^^^^^^^^^^^^
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/configure.py", line 138, in main
0:01.19 sandbox.include_file(os.path.join(os.path.dirname(file), "moz.configure"))
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 498, in include_file
0:01.19 exec(code, self)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/moz.configure", line 462, in <module>
0:01.19 include(include_project_configure)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 872, in include_impl
0:01.19 self.include_file(what)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 498, in include_file
0:01.19 exec(code, self)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/browser/moz.configure", line 19, in <module>
0:01.19 include("../toolkit/moz.configure")
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 872, in include_impl
0:01.19 self.include_file(what)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 498, in include_file
0:01.19 exec(code, self)
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/toolkit/moz.configure", line 3267, in <module>
0:01.19 depends("--enable-dbus", when=toolkit_gtk)(lambda x: x),
0:01.19 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/python/mozbuild/mozbuild/configure/init.py", line 835, in depends_impl
0:01.19 raise ConfigureError(
0:01.19 mozbuild.configure.ConfigureError: @depends function needs the same when
as options it depends on
*** Fix above errors and then restart with "./mach build"
Expected results:
I'll attach the full build log, if there are any configure logs I'm unaware and which you'd like to see please let me know.
I'm using --disable-dbus here, but --enable-dbus is broken as well.
Comment 1•9 months ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox Build System::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•9 months ago
|
||
:ahochheiden, since you are the author of the regressor, bug 1776255, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
Comment 3•9 months ago
|
||
0:01.19 File "/var/tmp/portage/www-client/firefox-128.0/work/firefox-128.0/toolkit/moz.configure", line 3267, in <module>
0:01.19 depends("--enable-dbus", when=toolkit_gtk)(lambda x: x),
Your source tree is not up-to-date. This line doesn't exist anymore. It was changed by the very bug you say caused the regression.
Updated•9 months ago
|
my copy of the source tree is def up-to-date - I redownloaded from https://github.com/mozilla/gecko-dev/commit/ccb101be8f27d837b655ccee51a52c0337dd1eb8 , and the same thing happened again
I also removed any dbus reference from configure line, didn't enable it and neither disabled it, and the same thing happened again.
Comment 5•9 months ago
|
||
You definitely don't have a pristine version of the code:
https://github.com/mozilla/gecko-dev/blob/ccb101be8f27d837b655ccee51a52c0337dd1eb8/toolkit/moz.configure#L3253
this is where the line I quoted in comment 3 used to be. As you can see, it doesn't look like what's in your error.
Description
•