189960 - Adding pop-up allowed exceptions don't stick

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect)

Description

[Steve Wardell]

I'm running 2003012105 trunk on XP. I have one site in the pop-up exceptions
allows sites. I go into the preferences and try to add another site. Everything
looks fine and the 2 sites are shown in my list of hosts. I click OK and exit
preferences. I return to that config and don't see the site I added.

Comment 1

[Boris Zbarsky [:bzbarsky]]

to danm/shliang

Comment 2

[sairuh (rarely reading bugmail)]

i cannot repro this using 2003.01.21.08 mozilla on win2k.

Comment 3

[Steve Wardell]

Please don't mark this as resolved so easily. I've confirmed this on another
system. 2003012108 trunk on XP. One thing to note is I initially add
www.bantu.office and www.bantu.com by clicking on the exclamation point when a
pop-up is blocked. I add these two sites. Click ok. Then I go into the
preferences and pop-up block exceptions and only www.bantu.com is there.

Comment 4

[Simon Spiegel]

I see this too with build 2003012709. Although the whitelsiting seems to work
(the whitelisted sites can open popups)they don't appear in the popup manager
window.

Comment 5

[sairuh (rarely reading bugmail)]

simon, what platform/os are you using?

Comment 6

[shliang]

Attachment: patch for one case

steve: could you give me some more specific steps? www.bantu.office isn't a
valid url, and www.bantu.com redirects to something else.

this patch addresses the case where you have something like "gap.com" on your
whitelist and you go to "www.gap.com" - in the menu "Allow popups from this
site" should be disabled since gap.com would cover *.gap.com. However, should
"Suppress popups from this site" be enabled though? If you wanted to block just
www.gap.com and allow the rest of *.gap.com, you would have to go back to your
prefs and use the blacklisting policy. I am not sure what the proper behavior
should be for cases like this. 

simon: what specific sites were you adding to your whitelist? if you were to
add two sites with the same superdomain then the more specific one would be
covered by the less specific one and therefore would not show up in your list.

Comment 7

[sairuh (rarely reading bugmail)]

shuehan, shouldn't your patch be applicable to bug 190351? if yes, let me know
if i should dup either this bug or that one. thanks!

Comment 8

[Steve Wardell]

www.bantu.office is a valid URL as we use it on our intranet. Other places use
things like companyname.internal and such.

Comment 9

[Steve Wardell]

Actually, let me clarify. You shouldn't need to access the sites I'm trying to
access just to verify that you could add them to the list and they show up on
the list of allowed sites.

Comment 10

[Simon Spiegel]

sairuh: I'm running Moz on WinXP. One site I added was www.igb.ch. The site
doesn't work properly on Moz, but this is not related to this bug. Anyway, popup
whitelisting works, I just don't see it in the manager.

Comment 11

[shliang]

steve: are you going to help me figure out what exactly is going wrong here or
not? i can't fix this problem if i can't reproduce this. it's not as if sites
are randomly disappearing from the whitelist, this is happening in specific
circumstances and i would need some more information from you to figure out what
these circumstances are. 

simon: i think this bug results from a combination of sites being added, not
just one. do you remember what the other sites you added were?

Comment 12

[Simon Spiegel]

I'm no programmer but I don't think this comes from a combination of sites. I
added different sites during different session and none of them ever sticked. Is
there a way I can delete the whitelist and start a new one? Right now the
"remove all" button is greyed out. Is there a file I can delete to start from
scratch?

Comment 13

[Simon Spiegel]

Ok, this works for me now using build 2003013008.

Comment 14

[Steve Wardell]

Fixed for me in 2003013104 trunk on W2K. Good job!

Comment 15

[shliang]

oh. this was probably a dup of bug 190371 then.

Comment 16

[sairuh (rarely reading bugmail)]

vrfy