1899671 - Update wildcard import in test files so it doesn't trigger ktlint error

Status: RESOLVED FIXED

(GeckoView :: General, task, P1)

Description

[Roger Yang [:royang]]

This was found when updating file with this import and it triggered the ktlint error.

The ktlint comment is not working. Investigate how to disable ktlint error for similar imports in test files.

Comment 1

[Roger Yang [:royang]]

The review is here

Comment 2

[Roger Yang [:royang]]

Attachment: Lint error.txt

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Should just be @file:Suppress("ktlint:standard:no-wildcard-imports") at the top of the file, no?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Adding that just gives a new error:

Step 'ktlint' found problem in 'src/androidTest/java/org/mozilla/geckoview/test/GeckoSessionTestRuleTest.kt':
Error on line: 1971, column: 54
rule: standard:curly-spacing
Unexpected newline before "{"

Do we know why this only started failing now all of a sudden? This is causing a lot of pain for me at the moment as it can break gradle-dependencies runs too.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Also, the line and column numbers being reported don't make any sense at all.

Comment 6

[Roger Yang [:royang]]

Attachment: Bug 1899671 - Add no wildcard imports suppression to GeckoSessionTestRuleTest.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cefcfbb3ba3
Add no wildcard imports suppression to GeckoSessionTestRuleTest. r=RyanVM

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/3cefcfbb3ba3

Comment 9

[Intermittent Failures Robot]

25 failures in 4202 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 6
• autoland: 19

Platform and build breakdown:

• lint: 25
  • opt: 25

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1899671&startday=2024-05-27&endday=2024-06-02&tree=all