1900108 - Replace/remove mochitests that does not need mock service

Status: RESOLVED FIXED

(Core :: DOM: Notifications, task)

Description

[Kagami Rosylight [:saschanaz] (they/them)]

dom/notification/test/mochitest/MockServices.js mocks nsIAlertsService but only on the content process, and thus it stops working with the change in bug 1891807. I think at least part of those tests are already covered by WPT and can go, and for others that require click events can go web-platform/mozilla with some test-only clicking function. Doing so will break the tests on GeckoView for now, but it doesn't make much sense there either when the actual nsIAlertsService backend is broken.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Bug 1901282 will do the migration, while it seems some tests doesn't need mock at all. This bug is about potential migration to WPT (or removal if already covered).

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1900108 - Part 1: Remove redundant NotificationTest.js imports r=asuth

Nobody uses it outside dom/notification.

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1900108 - Part 2: Remove redundant uses of mock service r=asuth

Some dom/workers tests depending on event handlers of Notification interface are broken on Android because of no support. This patch disables them for now as there's no point to hide the breakage by using the mock.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04a1568edf68
Part 1: Remove redundant NotificationTest.js imports r=asuth
https://hg.mozilla.org/integration/autoland/rev/112724a7654c
Part 2: Remove redundant uses of mock service r=asuth

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/04a1568edf68
https://hg.mozilla.org/mozilla-central/rev/112724a7654c