190014 - popup windows: should prefill whitelist and highlight blacklist entries

Status: VERIFIED INVALID

(SeaMonkey :: Preferences, defect)

Description

[sairuh (rarely reading bugmail)]

found using 2003.01.21.10 comm trunk builds. with the popup window feature, we
should prefill whitelist and highlight blacklist entries when the user either
clicks on the notification icon or selects Tools - Popup Manager - Manage Popup
Permissions.

it worked fine in Netscape 7.01, so it'd be nice to have this behavior in the trunk.

Comment 1

[sairuh (rarely reading bugmail)]

i believe shuehan already has a fix for this. woo!

Comment 2

[shliang]

Attachment: patch

Comment 3

[jag (Peter Annema)]

Comment on attachment 112223 [details] [diff] [review]
patch

sr=jag

Comment 4

[Jason Bassford]

*** Bug 190216 has been marked as a duplicate of this bug. ***

Comment 5

[Ben Ruppel]

Would it be technically possible for the popup blocked icon to load the blocked
window on the spot?  As I understand it, the current procedure would be:
A) perform action that would normally cause a popup (browse to window, click on
graphic)
B) click on icon, add site to whitelist
C) repeat action in A

Which is a little clunkier than it could be.  Something along the lines of:
Mouseover of popup icon shows blocked URL in the status bar
Right click of icon brings up whitelist dialog
Left click of icon loads the blocked url(s) in popup windows.

Comment 6

[shliang]

fixed last week

Comment 7

[sairuh (rarely reading bugmail)]

this works fine when i access Exceptions from the notification icon in the
status bar.

however, there's still no prefilling / highlighting when i access Exceptions via
the menu item Tools - Popup Manager - Manage Popup Permissions.

tested with 2003.02.03 comm trunk bits on linux rh7.2 and mac 10.2.3.

shuehan, i'm reopening this bug --but if you'd rather i file a separate one for
the menu item issue, let me know and this could be re-resolved. thanks!

Comment 8

[Samir Gehani]

Nav triage team: need info.  Is the menu item staying?  Shuehan, please update
us in the bug when a decision based on recent usability studies about the Tools
menu items has been made.  Thanks.

Comment 9

[Samir Gehani]

Nav triage team: Shuehan, can you supply requisite info please?  Is this still
an issue?  Thanks.

Comment 10

[sairuh (rarely reading bugmail)]

this is no longer an issue, due to bug 195924.

Comment 11

[sairuh (rarely reading bugmail)]

v