1900241 - Get helper_bug1783936.html to pass on Linux with overscroll enabled

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect)

Description

[Botond Ballo [:botond]]

When I tried to enable overscroll on Linux nightly in bug 1899918, I discovered that helper_bug1783936.html fails in that configuration.

This bug tracks fixing the underlying issues causing that failure.

Comment 1

[Botond Ballo [:botond]]

Attachment: Bug 1900241 - Make StateChangeNotificationBlocker moveable. r=dlrobertson

This can be useful in cases whre you want notifications blocked until
a task which will run on a different thread runs. In such cases, the
blocker can be moved into the task.

Also remove the MOZ_STACK_CLASS attribute since the usage pattern of
moving a blocker into a task means it won't always be on the stack.

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1900241 - Block state change notifications until deferred tasks are run in AdvanceAnimations(). r=dlrobertson

This has been the intention since bug 1053766, but was accidentally regressed
in bug 1451469 which split the sampler thread and the controller thread such
that the deferred tasks (which have to run on the controller thread) are no
longer run within the local scope of AdvnaceAnimations() (which runs on the
sampler thread).

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1900241 - Scroll snap with 'intended end position' only at the end of an overscroll animation. r=hiro

This is meant to be analogous to the call in SnapBackIfOverscrolled() in
the non-overscrolled case. The call there was updated to only use
'intended end position' in bug 1783936.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/300a430a5e27
Make StateChangeNotificationBlocker moveable. r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/34595a94ba10
Block state change notifications until deferred tasks are run in AdvanceAnimations(). r=dlrobertson
https://hg.mozilla.org/integration/autoland/rev/a978521130da
Scroll snap with 'intended end position' only at the end of an overscroll animation. r=hiro

Comment 5

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/300a430a5e27
https://hg.mozilla.org/mozilla-central/rev/34595a94ba10
https://hg.mozilla.org/mozilla-central/rev/a978521130da