1900317 - [wpt-sync] Sync PR 46588 - Don't use GetDoubleValue for scale property parsing

Status: RESOLVED FIXED

(Core :: Web Painting, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 46588 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/46588
Details from upstream follow.

Daniil Sakhapov <[e-mail]> wrote:

Don't use GetDoubleValue for scale property parsing

Bug: 40944203
Change-Id: Ibb98fbe2334b0f3cb7a8376ba22335c59bb62bda
Reviewed-on: https://chromium-review.googlesource.com/5585017
WPT-Export-Revision: 32b58d13182800d6801d1982d8f685068510682f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a84c7c13231c6ddbf88defa8e07c28c6d58e94d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 10 subtests

Status Summary

Firefox

OK : 1
FAIL: 10

Chrome

OK : 1
PASS: 10

Safari

OK : 1
FAIL: 10

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-transforms/transform-with-sign-function.html [wpt.fyi]
  • skew(calc(sign(1em - 1px) * 2deg), calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skew(2deg, 2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • skewX(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skewX(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • skewY(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to skewY(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • matrix(calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2)) should be used-value-equivalent to matrix(2, 2, 2, 2, 2, 2): FAIL (Chrome: PASS, Safari: FAIL)
  • matrix3d(calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2),calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2), calc(sign(1em - 1px) * 2)) should be used-value-equivalent to matrix3d(2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2, 2): FAIL (Chrome: PASS, Safari: FAIL)
  • rotate(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotate(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • rotateX(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateX(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • rotateY(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateY(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • rotateZ(calc(sign(1em - 1px) * 2deg)) should be used-value-equivalent to rotateZ(2deg): FAIL (Chrome: PASS, Safari: FAIL)
  • calc(sign(1em - 1px) * 2) calc(sign(1em - 1px) * 2) calc(sign(1em - 1px) * 2) should be used-value-equivalent to 2 2 2: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dced74f6222
[wpt PR 46588] - Don't use GetDoubleValue for scale property parsing, a=testonly
https://hg.mozilla.org/integration/autoland/rev/93dc4af8c4fe
[wpt PR 46588] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/6dced74f6222
https://hg.mozilla.org/mozilla-central/rev/93dc4af8c4fe