1900391 - [megalist] Support varying row heights in VirtualizedList

Status: RESOLVED FIXED

(Toolkit :: Password Manager, task, P3)

Description

[Micah [:mtigley] (she/her)]

Currently, VirtualizedList only supports a single fixed row height for the whole list.

To be more flexible with our UI, the VirtualizedList should support being able to render varying row heights.

Comment 1

[Issam Mani [:issammani]]

Attachment: Bug 1900391 - Support dynamic row heights in virtualized list. r=mtigley!

Comment 2

[Micah [:mtigley] (she/her)]

Attachment: Bug 1900391 - Use a virtual list for the passwords list. r=mtigley

Comment 3

[Micah [:mtigley] (she/her)]

Attachment: Bug 1900391 - P2: Migrate VirtualizedList chrome tests to a browser test. r=rsafaeian!

Depends on D226702

Comment 4

[Dimi Lee [:dimi]]

Attachment: Bug 1900391 - Integrate virtual list to context password manager r=mtigley

Depends on D226702

Comment 5

[Dimi Lee [:dimi]]

Attachment: Bug 1900391 - Use a virtual list for the passwords list. r=mtigley

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/61f597cd7a16
https://hg.mozilla.org/integration/autoland/rev/d99d2a2d1cd3
Use a virtual list for the passwords list. r=mtigley,credential-management-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1964b6b2c594
https://hg.mozilla.org/integration/autoland/rev/f6b4963488a5
Revert "Bug 1900391 - Use a virtual list for the passwords list. r=mtigley,credential-management-reviewers" for causing mochitests failures in browser_passwords_delete_login.js.

Comment 8

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_passwords_delete_login.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/satchel/megalist/content/tests/browser/browser_passwords_delete_login.js | Uncaught exception in test bound test_delete_login_success - at chrome://mochitests/content/browser/toolkit/components/satchel/megalist/content/tests/browser/browser_passwords_delete_login.js:29 - TypeError: can't access property "querySelector", list.shadowRoot is null

Comment 9

[Dimi Lee [:dimi]]

Attachment: Bug 1900391 - Port virtual list support changes from Contextual Password Manager to Firefox View

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/636adf7332b7
https://hg.mozilla.org/integration/autoland/rev/01c1939336d1
Use a virtual list for the passwords list. r=mtigley,credential-management-reviewers

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/01c1939336d1

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6a0b366f7333
https://hg.mozilla.org/integration/autoland/rev/7fa5e6c8670b
Port virtual list support changes from Contextual Password Manager to Firefox View r=kcochrane,sclements,fxview-reviewers

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b128b27984c9
https://hg.mozilla.org/integration/autoland/rev/7ce6264a8c45
Revert "Bug 1900391 - Port virtual list support changes from Contextual Password Manager to Firefox View r=kcochrane,sclements,fxview-reviewers" for causing bc failure on browser_firefoxview_virtual_list.js

Comment 14

[Narcis Beleuzu [:NarcisB]]

Backed out for causing bc failure on browser_firefoxview_virtual_list.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/7ce6264a8c45510fe4a171349aec1774eef82237
Log link: https://treeherder.mozilla.org/logviewer?job_id=536016562&repo=autoland&task=QRqXCW65TH-lPlkHLrqtjw.0&lineNumber=7249