1900649 - "Restart Nightly" button in crash reporter gets truncated in Turkish

Status: VERIFIED FIXED

(Toolkit :: Crash Reporting, defect)

Description

[Selim Şumlu]

Attachment: restart nightly.png

"Restart Nightly" button in the crash reporter is truncated in Turkish.

Full text should read "Nightly uygulamasını yeniden başlat".

This also makes me think that "Restart Firefox Developer Edition" in English might get truncated as well, but I haven't tested that.

Comment 1

[Gabriele Svelto [:gsvelto]]

Thanks for testing this Selim, cc'ing Alex who did all the work here.

Comment 2

[Alex Franchuk [:afranchuk]]

The problem here is that the old crash reporter made the buttons the same width (to be more visually appealing, I expect), so I did the same. However I made it a fixed size rather than a minimum size.

Comment 3

[Alex Franchuk [:afranchuk]]

This is windows-only: in the macos (cocoa) and gtk implementations, the size is set as a minimum. On windows there's no easy way to set a minimum (as win32 doesn't have any concept of layout), so I'll have to implement it myself.

Comment 4

[Alex Franchuk [:afranchuk]]

Attachment: Bug 1900649 - crash reporter: use size requests as minimum sizes on windows r=gsvelto

This is the behavior of the other platforms. It allows buttons with
longer labels to be sized correctly.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e301fb9fb678
crash reporter: use size requests as minimum sizes on windows r=gsvelto

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e301fb9fb678

Comment 7

[Catalin Sasca, Desktop Test Engineering [:csasca]]

Reproduced the issue on Firefox 128.0a1 (2024-06-04) on Windows 11 by following the STR from Comment 0.

The issue is fixed on Firefox 128.0b1 and 129.0a1 (2024-06-11). Tests were performed on Windows 11, macOS 14.5 and Ubuntu 24.04.