1900835 - Switch PanelMultiView keyboard focus handling to use Element.focus() rather than Services.focus.setFocus()

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, task, P2)

Description

[Mark Striemer [:mstriemer]]

In bug 1539984 PanelMultiView was updated to use Services.focus.setFocus() so that we can specify that the focus changed due to a keyboard event and show focus outline on :-moz-focusring/:focus-visible. Since then, bug 1711057 has updated our handling of Element.focus() calls so that if this is called during a keyboard event handler it automatically sets that the element was focused from the keyboard.

The distinction between these two calls comes into play when a custom element defines its own focus() method. For example in bug 1897212 our moz-toggle component is moving away from the shadow DOM delegatesFocus property since that has some unfortunate side effects like clicking on descriptive text focusing the toggle input. With that change however, PanelMultiView now attempts to focus the custom element host, rather than the toggle input since the focus() method is not called.

Since both Services.focus.setFocus() and Element.focus() will behave the same way in terms of showing the focusring we should prefer the Element.focus() call to that custom elements can specify where the focus should be moved within their shadow DOM.

Comment 1

[Irene Ni [:ini]]

Attachment: Bug 1900835 - Switch PanelMultiView keyboard focus handling to use Element.focus() rather than Services.focus.setFocus()

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2028c8383352
Switch PanelMultiView keyboard focus handling to use Element.focus() rather than Services.focus.setFocus() r=mstriemer,Gijs

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2028c8383352