Closed Bug 1901016 Opened 1 year ago Closed 1 year ago

Remove descriptions from text and tracing marker schemas

Categories

(Core :: Gecko Profiler, task, P3)

task

Tracking

()

RESOLVED FIXED
129 Branch
Tracking Status
firefox129 --- fixed

People

(Reporter: canova, Assigned: canova)

Details

Attachments

(1 file)

After renewing our marker schemes, "descriptions" were added to both text and tracing markers schemes. They don't really provide a lot of value to the users because this is an implementation detail and because users shouldn't need to know about which marker has which schema type really.

Here's a profile example you can see both text and tracing examples with their descriptions: https://share.firefox.dev/4aNT4gN

It's really not possible to add a single meaningful description to these marker
types since they can be used by various marker types. Previous descriptions
were not really descriptive or helpful for the users. They were just explaining
some implementation details which our users don't need to know.

For the implementation details, we already check if this Description field
is nullptr or not, and if it's falsy we don't serialize this field at all:
https://searchfox.org/mozilla-central/rev/d3fea1aa852bb3a353a0a4a875c3685da11ce39b/mozglue/baseprofiler/public/BaseProfilerMarkersPrerequisites.h#1064-1066

Assignee: nobody → canaltinova
Status: NEW → ASSIGNED
Pushed by canaltinova@gmail.com: https://hg.mozilla.org/integration/autoland/rev/b549fde2ba48 Remove descriptions from text and tracing marker schemas r=profiler-reviewers,julienw
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: