Closed Bug 1901033 Opened 2 years ago Closed 2 years ago

add image_builder_arm64 docker image

Categories

(Firefox Build System :: Task Configuration, task)

task

Tracking

(firefox-esr115 fixed, firefox129 fixed)

RESOLVED FIXED
129 Branch
Tracking Status
firefox-esr115 --- fixed
firefox129 --- fixed

People

(Reporter: jcristau, Assigned: jcristau)

References

Details

Attachments

(15 files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → jcristau
Status: NEW → ASSIGNED

Replace successive RUN commands with small shell scripts, to make it
easier to add arm64 support.

Looks like kaniko now handles VOLUME instructions before anything else,
so by the time we get to RUN mkdir, /build already exists.

Adjust kaniko arguments passed in by build-image:

  • pass --cache=true to kaniko, otherwise it seems to look for an image named
    "parent" on docker hub instead of looking at the tar we put in the cache dir
  • pass a cache-repo to kaniko, otherwise it refuses to enable caching
    (https://github.com/GoogleContainerTools/kaniko/pull/374)

kaniko runs out of memory when building large images such as updatebot;
disabling compressed caching helps.

We use the cache to feed the parent image to kaniko, we don't need to
push anything back to it.

Attachment #9406387 - Attachment description: Bug 1901033 - image_builder: bump dependencies and rustc version. r?glandium → Bug 1901033 - image_builder: update rust library dependencies.
Attachment #9406388 - Attachment description: Bug 1901033 - build-image: output exit code or signal when subprocesses fail. → Bug 1901033 - image_builder: print exit code or signal when subprocesses fail.
Pushed by jcristau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1deab1c805f8 image_builder: bump rustc to 1.52.0. r=glandium https://hg.mozilla.org/integration/autoland/rev/cb44e52eebb8 image_builder: update Cargo.lock format to version 3. r=glandium https://hg.mozilla.org/integration/autoland/rev/b9020a9e3a01 image_builder: update socket2 crate to fix build with recent rustc. r=glandium https://hg.mozilla.org/integration/autoland/rev/94ddd5078006 image_builder: bump rustc to 1.76.0. r=glandium https://hg.mozilla.org/integration/autoland/rev/e6487cd2d51c image_builder: update rust library dependencies. r=glandium https://hg.mozilla.org/integration/autoland/rev/b8bc3d254302 image_builder: print exit code or signal when subprocesses fail. r=glandium https://hg.mozilla.org/integration/autoland/rev/bdfb12840982 image_builder: refactor dockerfile. r=glandium https://hg.mozilla.org/integration/autoland/rev/11d539194c48 prepare debian-base and ubuntu1804-base docker images for new kaniko. r=glandium https://hg.mozilla.org/integration/autoland/rev/55df8fca8ebb image_builder: update kaniko and skopeo. r=glandium https://hg.mozilla.org/integration/autoland/rev/1e8e13f84b51 image_builder: disable compressed caching. r=glandium https://hg.mozilla.org/integration/autoland/rev/1ccb0c3e4ce0 image_builder: pass --no-push-cache to kaniko r=glandium https://hg.mozilla.org/integration/autoland/rev/11d0c25bdb8a image_builder: use debian:12 instead of 10. r=glandium https://hg.mozilla.org/integration/autoland/rev/c1ee1af5b8df add image_builder_arm64 docker image r=glandium https://hg.mozilla.org/integration/autoland/rev/a20de1f68b26 image_builder: bump version to 5.1.0. r=glandium
Duplicate of this bug: 1806676
Blocks: 2019973

Looks like kaniko now handles VOLUME instructions before anything else,
so by the time we get to RUN mkdir, /build already exists.

Original Revision: https://phabricator.services.mozilla.com/D213061

Attachment #9558551 - Flags: approval-mozilla-esr115?

firefox-esr115 Uplift Approval Request

  • User impact if declined/Reason for urgency: bustage fix
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: n/a
  • Risk associated with taking this patch: low
  • Explanation of risk level: fixes for CI docker image builds
  • String changes made/needed?: n/a
  • Is Android affected?: no
Attachment #9558551 - Flags: approval-mozilla-esr115? → approval-mozilla-esr115+
QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: