1901264 - Ensure Settings search works with moz-checkbox and moz-radio-group

Status: RESOLVED FIXED

(Firefox :: Settings UI, task, P1)

Description

[Mark Striemer [:mstriemer]]

The search feature only searches within nodes that it expects to have settings content within them. This will now include moz-checkbox, moz-radio-group and moz-radio.

Comment 1

[:Gijs (he/him)]

This would be S2 if we shipped any of these as yet, but AIUI that hasn't happened yet? If I'm misunderstanding then we can upgrade. :-)

(P1 as there's an assignee - thanks Hanna!)

Comment 2

[Hanna Jones [:hjones]]

Attachment: Bug 1901264 - update settings search to work for all moz- prefixed custom elements r=#recomp-reviewers,#preferences-reviewers

This patch:

• adds some simple logic to settins search that should prevent us from having to manually allow searching in every moz- prefixed custom element
• cleans up the existing settings search logic slightly for improved readability
• expands the tests to check searching for text in the shadow DOM of additional moz- prefixed custom elements

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68ddeed4435e
update settings search to work for all moz- prefixed custom elements r=reusable-components-reviewers,settings-reviewers,mstriemer

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/68ddeed4435e