Closed Bug 1901374 Opened 1 year ago Closed 1 year ago

Implement parsing support for field-sizing

Categories

(Core :: CSS Parsing and Computation, task)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: lwarlow, Assigned: lwarlow)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file)

Bug 1901374: Implement field-sizing parsing r?emilio
48 bytes, text/x-phabricator-request
Details | Review
Assignee: nobody → lwarlow
Status: NEW → ASSIGNED

This change adds a new layout.css.field-sizing.enabled pref that controls the availability of the field-sizing CSS property.

With the pref enabled this property now parses according to the spec.

Spec: https://drafts.csswg.org/css-ui/#field-sizing

Blocks: 1901376
Blocks: 1901379
Pushed by luke@warlow.dev: https://hg.mozilla.org/integration/autoland/rev/b50c8f1824f0 Implement field-sizing parsing r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46684 for changes under testing/web-platform/tests

Backed out for causing wpt failures on field-sizing-computed.html and mochitest failures on test_animation-type-longhand.html.

[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - TEST-PASS | /css/css-ui/parsing/cursor-valid.html | e.style['cursor'] = "image-set(\"https://example.com/\" 1x, \"https://example.com/highres\" 2x) 5 6, grab" should set the property value 
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - TEST-UNEXPECTED-FAIL | /css/css-ui/parsing/field-sizing-computed.html | Property field-sizing value 'fixed' - assert_true: field-sizing doesn't seem to be supported in the computed style expected true got false
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:24:16
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2622:25
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - test@http://web-platform.test:8000/resources/testharness.js:633:30
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:22:7
[task 2024-06-11T01:59:21.783Z] 01:59:21     INFO - @http://web-platform.test:8000/css/css-ui/parsing/field-sizing-computed.html:11:20
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - 
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - TEST-UNEXPECTED-FAIL | /css/css-ui/parsing/field-sizing-computed.html | Property field-sizing value 'content' - assert_true: field-sizing doesn't seem to be supported in the computed style expected true got false
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - test_computed_value/<@http://web-platform.test:8000/css/support/computed-testcommon.js:24:16
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2622:25
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - test@http://web-platform.test:8000/resources/testharness.js:633:30
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - test_computed_value@http://web-platform.test:8000/css/support/computed-testcommon.js:22:7
[task 2024-06-11T01:59:21.784Z] 01:59:21     INFO - @http://web-platform.test:8000/css/css-ui/parsing/field-sizing-computed.html:12:20
[task 2024-06-11T01:59:21.842Z] 01:59:21     INFO - TEST-OK | /css/css-ui/parsing/field-sizing-computed.html | took 744ms
[task 2024-06-11T01:59:22.123Z] 01:59:22     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2024-06-11T01:59:22.224Z] 01:59:22     INFO - STDOUT: cleanup aborted: Unable to remount device
[task 2024-06-11T01:59:22.225Z] 01:59:22     INFO - Closing logging queue
[task 2024-06-11T01:59:22.225Z] 01:59:22     INFO - queue closed
[task 2024-06-11T01:59:22.239Z] 01:59:22     INFO - Setting up ssl
[task 2024-06-11T01:59:22.472Z] 01:59:22     INFO - certutil | b''
[task 2024-06-11T01:59:22.631Z] 01:59:22     INFO - certutil | b''
[task 2024-06-11T01:59:22.639Z] 01:59:22     INFO - certutil | b'\nCertificate Nickname                                         Trust Attributes\n                                                             SSL,S/MIME,JAR/XPI\n\nweb-platform-tests                                           CT,, \n'
[task 2024-06-11T01:59:23.100Z] 01:59:23     INFO - adb Granting important runtime permissions to org.mozilla.geckoview.test_runner
[task 2024-06-11T01:59:24.126Z] 01:59:24     INFO - adb launch_application: am start -W -n org.mozilla.geckoview.test_runner/org.mozilla.geckoview.test_runner.TestRunnerActivity -a android.intent.action.MAIN --es env0 MOZ_CRASHREPORTER=1 --es env1 MOZ_CRASHREPORTER_NO_REPORT=1 --es env2 MOZ_CRASHREPORTER_SHUTDOWN=1 --es env3 MOZ_HIDE_RESULTS_TABLE=1 --es env4 MOZ_IN_AUTOMATION=1 --es env5 MOZ_LOG=signaling:3,mtransport:4,DataChannel:4,jsep:4 --es env6 R_LOG_LEVEL=6 --es env7 R_LOG_DESTINATION=stderr --es env8 R_LOG_VERBOSE=1 --es env9 MOZ_PROCESS_LOG=/tmp/tmp56yjk55upidlog --es env10 MOZ_DISABLE_NONLOCAL_CONNECTIONS=1 --es arg0 -no-remote --es arg1 -profile --es arg2 /data/local/tmp/test_root/profile --es arg3 --marionette --es arg4 about:blank
[task 2024-06-11T01:59:25.399Z] 01:59:25     INFO - Starting runner
[task 2024-06-11T01:59:28.201Z] 01:59:28     INFO - TEST-START | /css/css-ui/parsing/field-sizing-invalid.html
Flags: needinfo?(lwarlow)
Upstream PR was closed without merging

Emilio do you know why this would have backed out, it looks as if the flag isn't enabled in the tests?

Flags: needinfo?(lwarlow) → needinfo?(emilio)

Ah, d'oh, the __dir__.ini file needs to be in testing/web-platform/meta/css/css-ui, sorry for missing that.

Flags: needinfo?(emilio)

Backed out for causing mochitest failures on test_animation-type-longhand.html

Flags: needinfo?(lwarlow)
Pushed by acseh@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/e1b316eca9ec Implement field-sizing parsing r=emilio

Okay at this point I'm very confused as to whether this has landed or not. I tried to re-land in lando but idk if the backout confused it. I'd appreciate some help to see if it's made it it or not.

It got backed out again, I think I've tracked down the cause in a devtools test which wasn't ran on the try bots.

Flags: needinfo?(lwarlow)
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cc71258b1f91 Implement field-sizing parsing r=emilio

https://hg.mozilla.org/mozilla-central/rev/cc71258b1f91

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
Blocks: 1977176
Blocks: 1977177
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: