1901488 - "Never translate English" option is always disabled

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[Claas Augner [:claas]]

Attachment: screenshot.png

Version: 128.0a1 (2024-06-09) (64-bit)

Steps to reproduce:

1. Go to https://developer.mozilla.org/en-US/
2. Click on the Firefox Translate icon.
3. Click on the Settings icon.
4. Notice that "Never translate English" is disabled.

I started noticing this issue these days, possibly after changing my browser language to "German (Germany)" without including English, but after adding "English" back, the option is still disabled.

Comment 1

[Greg Tatum [:gregtatum]]

I can't reproduce on my end.

:claas Can you provide the exact list of languages, and their orders from about:preferences from "Choose your preferred languages for displaying pages".

Comment 2

[Claas Augner [:claas]]

:gregtatum, here is the list of languages in the "Webpage Language Settings" ("Choose your preferred language for displaying pages"):

1. German (Germany) [de-de]

Comment 3

[Greg Tatum [:gregtatum]]

Thanks, I finally reproduced:

STR:

• Open an English build of Firefox.
• Add German to "Webpage language settings"
• Remove all other languages
• Go to https://developer.mozilla.org/en-US/
• Click on the Firefox Translate icon.
• Click on the Settings icon.
• Notice that "Never translate English" is disabled.

Comment 4

[Greg Tatum [:gregtatum]]

Attachment: Bug 1901488 - Fix issue where the never translate button is disabled; r?#translations-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3fcea81cb0b
Fix issue where the never translate button is disabled; r=translations-reviewers,nordzilla

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d3fcea81cb0b

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:gregtatum, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox129 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Greg Tatum [:gregtatum]]

This is an edge case.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on Firefox 129.0 on Windows 10 using the STR from Comment 3.
Verified as fixed on Firefox 130.0b2 and Firefox Nightly 131.0a1 on Windows 10, Ubuntu 22, macOS 14.