Closed Bug 1901517 Opened 1 year ago Closed 1 year ago

DecryptingInputStream::Seek can leave incorrect state after a failure

Categories

(Core :: Storage: Quota Manager, defect, P2)

Product:
Core
Component:
Storage: Quota Manager
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
129 Branch
Tracking Flags:
Tracking Status
firefox129 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(1 file)

Bug 1901517 - Restore previous state after a faiure in DecryptingInputStream::Seek; r=#dom-storage
48 bytes, text/x-phabricator-request
Details | Review

There are already XXX comments about restoring previous state like:
https://searchfox.org/mozilla-central/rev/46d0387f0b582f00a5722c20d4e6b8693793631b/dom/quota/DecryptingInputStream_impl.h#415
which are mostly about failed calls.
However, DecryptingInputStream::Seek can leave incorrect state after failed boundary checks as well.

Blocks: 1901525
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d9cbb91012e1 Restore previous state after a faiure in DecryptingInputStream::Seek; r=hsingh

https://hg.mozilla.org/mozilla-central/rev/d9cbb91012e1

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox129: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: