1901520 - Style the generated single-archive file to match the specification

Status: RESOLVED FIXED

(Firefox :: Profile Backup, task, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

This will involve:

1. Adding the ability to send template strings down to the archive worker
2. Adding the ability for the template strings to get (securely!) interpolated into the document template. We might want to take this opportunity to sanitize the metadata that gets computed for a backup.
3. Adding styles and script to the HTML document template. To make this easier, we might split these out to separate files that get joined together to the final template at build-time by the pre-processor.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1901520 - Part 1: Send localized template down to the archive worker. r?#backup-reviewers!

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1901520 - Part 2: Add styles and scripts to the single file archive. r?#backup-reviewers!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1901520 - Part 3: Add tests for the rendered template. r?#backup-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d98566735ad
Part 1: Send localized template down to the archive worker. r=backup-reviewers,fluent-reviewers,kpatenio,bolsson
https://hg.mozilla.org/integration/autoland/rev/5509d1905d2c
Part 2: Add styles and scripts to the single file archive. r=backup-reviewers,frontend-codestyle-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/4b079909d830
Part 3: Add tests for the rendered template. r=backup-reviewers,kpatenio

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures @ test_BackupService_renderTemplate.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/ba3427ddddb6b457ba8ab233bc0e6506aa9bc350

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/backup/tests/xpcshell/test_BackupService_renderTemplate.js | xpcshell return code: 1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d2914d4cff6
Part 1: Send localized template down to the archive worker. r=backup-reviewers,fluent-reviewers,kpatenio,bolsson
https://hg.mozilla.org/integration/autoland/rev/f3c21d943872
Part 2: Add styles and scripts to the single file archive. r=backup-reviewers,frontend-codestyle-reviewers,kpatenio
https://hg.mozilla.org/integration/autoland/rev/3615ef523168
Part 3: Add tests for the rendered template. r=backup-reviewers,kpatenio

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6d2914d4cff6
https://hg.mozilla.org/mozilla-central/rev/f3c21d943872
https://hg.mozilla.org/mozilla-central/rev/3615ef523168