Closed
Bug 1901626
Opened 1 year ago
Closed 1 year ago
Remove waitForCondition from Translations Telemetry Assertions
Categories
(Firefox :: Translations, task)
Firefox
Translations
Tracking
()
RESOLVED
FIXED
129 Branch
| Tracking | Status | |
|---|---|---|
| firefox129 | --- | fixed |
People
(Reporter: nordzilla, Assigned: nordzilla)
Details
Attachments
(1 file)
Description
Before Chris and I discovered/fixed Bug 1900085, I had added some waitForCondition calls to the telemetry test in an attempt to reduce intermittent failures.
These calls shouldn't be needed, and only add unnecessary complexity to the code at this point. We should remove them.
Steps to implement
- Remove the
waitForConditioncalls in theTestTranslationsTelemetryclass functions.
Tests to implement
- These functions are used for tests, so existing test cases are sufficient.
|
Assignee | |
Comment 1•1 year ago
|
||
Removes all calls to waitForCondition that are used
within the TestTranslationsTelemetry functions, because
they were added to try to reduce intermittent test failures
but were found to not be related to the now-fixed failures.
Depends on D213160
|
||
Updated•1 year ago
|
Attachment #9406518 -
Attachment description: WIP: Bug 1901626 - Remove waitForCondition calls in TestTranslationsTelemetry r=#translations-reviewers!,ohall → Bug 1901626 - Remove waitForCondition calls in TestTranslationsTelemetry r=#translations-reviewers!,ohall
Pushed by enordin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e99612d57688
Remove waitForCondition calls in TestTranslationsTelemetry r=ohall,translations-reviewers
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox129:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 129 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•