1901792 - Confirm PPA is disabled in PBM

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Brian Grinstead [:bgrins]]

PPA shouldn't function in Private Browsing. Confirm whether this is already the case from the initial landing, or update it and uplift to 128.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1901792 - Make PPA not work in PBM. r=bgrins

Comment 2

[Brian Grinstead [:bgrins]]

To elaborate on the motivation here, the implementation currently:

1. persists information to disc
2. doesn't compartmentalize by context (PBM, containers, etc)

While both of these could technically be fixed, the easiest & most straightforward thing to do unless/until that happens is to disable the feature in PBM

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/835ccc78eff2
Make PPA not work in PBM. r=bgrins

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/835ccc78eff2

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Sounds like this needs a Beta uplift request?

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 9406673 [details]
Bug 1901792 - Make PPA not work in PBM. r=bgrins

Beta/Release Uplift Approval Request

• User impact if declined: Comment 0
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Adds a simple private browsing check to an API that we're not shipping yet.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9406673 [details]
Bug 1901792 - Make PPA not work in PBM. r=bgrins

Approved for 128.0b5.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2a55a51e0343