1901830 - Speedup session store serialization by ~25x

Status: RESOLVED FIXED

(Firefox for Android :: Browser Engine, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

When serializing the session store information we were spending the bulk
of the time doing charset conversion because the JsonWriter writes a
character at a time and charset conversion has a large fixed overhead.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1901830 - Speedup session store serialization by ~25x

When serializing the session store information we were spending the bulk
of the time doing charset conversion because the JsonWriter writes a
character at a time and charset conversion has a large fixed overhead.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14a551dac67f
Speedup session store serialization by ~25x r=android-reviewers,kaya

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/14a551dac67f

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9406726 [details]
Bug 1901830 - Speedup session store serialization by ~25x

Beta/Release Uplift Approval Request

• User impact if declined: Saving session store can use up a significant amount of CPU time during tab switching. This is especially noticeable with sessions that are larger ~80+ tabs. During tab switch we have a lot of other important work to do so it's not a good time be wasting CPU.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's basically a one line fix that should have no functional differences. If it builds it's very likely to work.
• String changes made/needed:
• Is Android affected?: Yes

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9406726 [details]
Bug 1901830 - Speedup session store serialization by ~25x

Approved for 128.0b4.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/acf1b76b8adc

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9406726 [details]
Bug 1901830 - Speedup session store serialization by ~25x

Beta/Release Uplift Approval Request

• User impact if declined: Saving session store can use up a significant amount of CPU time during tab switching. This is especially noticeable with sessions that are larger ~80+ tabs. During tab switch we have a lot of other important work to do so it's not a good time be wasting CPU.

This isn't worth causing a dot release but if we decided to do one it would be nice to ride along.

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's basically a one line fix that should have no functional differences. If it builds it's very likely to work. It's also baked in Nightly and Beta for a while.
• String changes made/needed:
• Is Android affected?: Yes

Comment 9

[Donal Meehan [:dmeehan]]

Comment on attachment 9406726 [details]
Bug 1901830 - Speedup session store serialization by ~25x

Rejecting release uplift request. Fx128 merges to release on Monday 2024-07-01.
We don't have any Fx127 dot release planned before then.