1901852 - update-verify-config-creator local repo query fails for Thunderbird

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, task)

Description

[Rob Lemley [:rjl]]

update-verify-config-creator is throwing tons of errors like:

[task 2024-06-03T20:52:34.413Z] abort: mail/locales/shipped-locales not under root '/builds/worker/checkouts/gecko/comm'
[task 2024-06-03T20:52:34.413Z] (consider using '--cwd comm')
[task 2024-06-03T20:52:34.432Z] 20:52:34     INFO - retry: Calling _urlopen with args: (), kwargs: {'url': 'https://hg.mozilla.org/releases/comm-beta/raw-file/THUNDERBIRD_123_0b1_RELEASE/mail/locales/shipped-locales'}, attempt #1

The urlopen succeeds and the job continues, but the local query should succeed.

Ran through debugger:

> /home/rob/moz/m-b/testing/mozharness/scripts/release/update-verify-config-creator.py(457)_get_file_from_repo()
-> subprocess.check_output(
(Pdb) os.getcwd()
'/home/rob/moz/m-b'
(Pdb) rev
'THUNDERBIRD_127_0b5_RELEASE'
(Pdb) path
'mail/locales/shipped-locales'
(Pdb) subprocess.check_output(["hg", "-R", self.config["local_repo"], "cat", "-r", rev, path])
abort: mail/locales/shipped-locales not under root '/home/rob/moz/m-b/comm'
(consider using '--cwd comm')
*** subprocess.CalledProcessError: Command '['hg', '-R', 'comm/.', 'cat', '-r', 'THUNDERBIRD_127_0b5_RELEASE', 'mail/locales/shipped-locales']' returned non-zero exit status 255.
(Pdb) subprocess.check_output(["hg", "--cwd", self.config["local_repo"], "cat", "-r", rev, path])
b'af\nar\nast\nbe\nbg\nbr\nca\ncak\ncs\ncy\nda\nde\ndsb\nel\nen-CA\nen-GB\nen-US\nes-AR\nes-ES\nes-MX\net\neu\nfi\nfr\nfy-NL\nga-IE\ngd\ngl\nhe\nhr\nhsb\nhu\nhy-AM\nid\nis\nit\nja\nja-JP-mac\nka\nkab\nkk\nko\nlt\nlv\nms\nnb-NO\nnl\nnn-NO\npa-IN\npl\npt-BR\npt-PT\nrm\nro\nru\nsk\nsl\nsq\nsr\nsv-SE\nth\ntr\nuk\nuz\nvi\nzh-CN\nzh-TW\n'

Apparently --cwd works while -R is not.

Comment 1

[Rob Lemley [:rjl]]

Ahh ... to use -R the path would need to include the local-repo path a second time.

(Pdb) subprocess.check_output(["hg", "-R", self.config["local_repo"], "cat", "-r", rev, f"comm/{path}"])
b'af\nar\nast\nbe\nbg\nbr\nca\ncak\ncs\ncy\nda\nde\ndsb\nel\nen-CA\nen-GB\nen-US\nes-AR\nes-ES\nes-MX\net\neu\nfi\nfr\nfy-NL\nga-IE\ngd\ngl\nhe\nhr\nhsb\nhu\nhy-AM\nid\nis\nit\nja\nja-JP-mac\nka\nkab\nkk\nko\nlt\nlv\nms\nnb-NO\nnl\nnn-NO\npa-IN\npl\npt-BR\npt-PT\nrm\nro\nru\nsk\nsl\nsq\nsr\nsv-SE\nth\ntr\nuk\nuz\nvi\nzh-CN\nzh-TW\n'

Makes more sense to me to just use --cwd.

Comment 2

[Rob Lemley [:rjl]]

Attachment: Bug 1901852 - Use `--cwd` rather than `-R` for querying local repo in update-verify-config-creator. r=#releng-reviewers

With -R, the command always fails for Thunderbird, causing fallback to hg.mo.

Comment 3

[Rob Lemley [:rjl]]

Attachment: Bug 1901852 - Use `--cwd` rather than `-R` for querying local repo in update-verify-config-creator. r=#releng-reviewers

With -R, the command always fails for Thunderbird, causing fallback to hg.mo.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d9630152c6ab
Use `--cwd` rather than `-R` for querying local repo in update-verify-config-creator. r=releng-reviewers,gabriel

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d9630152c6ab

Comment 6

[Rob Lemley [:rjl]]

Comment on attachment 9406808 [details]
Bug 1901852 - Use --cwd rather than -R for querying local repo in update-verify-config-creator. r=#releng-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: N/A This is an automation fix.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce: Review update-verify-config logs and verify that files are pulled from the local repo rather than hgmo.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Low risk. This fixes an issue for Thunderbird where the local repo lookup failed during update-verify-config, causing fallback to hgmo every time.

I changed an argument to hg -- hg -R {repo_path} --> hg --cwd {repo_path}. The difference is subtle, but should not matter for Firefox as repo_path == cwd already. For Thunderbird it will look up files without prefixing "comm" to the file path to check.

• String changes made/needed: no
• Is Android affected?: No

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9406808 [details]
Bug 1901852 - Use --cwd rather than -R for querying local repo in update-verify-config-creator. r=#releng-reviewers

Approved for 128.0b4.

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2d48ac992928