1901930 - Fix inconsistency regarding messageDisplay.getDisplayedMessages() and mailTabs.getSelectedMessages()

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, task)

Description

[John Bieling]

We introduced message lists in order to cope with large amount of returned messages. We should be consistent in its usage. The number of displayed messages can be as large as the number of selected messages, so both functions should behave the same.

Comment 1

[John Bieling]

Attachment: Bug 1901930 - Fix inconsistency regarding messageDisplay.getDisplayedMessages() and mailTabs.getSelectedMessages() in Manifest V3. r=#thunderbird-reviewers

We introduced message lists in order to cope with large amount of
returned messages. We should be consistent in its usage. The number of
displayed messages can be as large as the number of selected messages,
so both functions should behave the same.

The only other place where we still return messages as plain arrays is
in the compose API, when returning the saved/send messages, which is
limited to only a few messages. It is acceptable to keep returning these
in an array.

This change is only affecting Manifest V3.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6928290ca41a
Fix inconsistency regarding messageDisplay.getDisplayedMessages() and mailTabs.getSelectedMessages() in Manifest V3. r=mkmelin

Comment 3

[John Bieling]

Comment on attachment 9406904 [details]
Bug 1901930 - Fix inconsistency regarding messageDisplay.getDisplayedMessages() and mailTabs.getSelectedMessages() in Manifest V3. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): -
User impact if declined: Inconsistent API behavior. ESR 128 is our launch for official Manifest V3 support and we worked hard to get it ready. This was not ready in time by a few days.
Testing completed (on c-c, etc.): none (besides automated tests)
Risk to taking this patch (and alternatives if risky): Low

Comment 4

[Wayne Mery (:wsmwk)]

Comment on attachment 9406904 [details]
Bug 1901930 - Fix inconsistency regarding messageDisplay.getDisplayedMessages() and mailTabs.getSelectedMessages() in Manifest V3. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 5

[Rob Lemley [:rjl]]

Thunderbird 128.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/3040976ed2ca