1901993 - Action buttons hidden when list of permissions is longer than the screen is tall in permission pop up

Status: RESOLVED FIXED

(Firefox for Android :: WebExtensions, defect)

Description

[Juliana Gaibler [:juliana]]

Attachment: Video recording of the bug

Steps to reproduce

Install an extension with more permissions than can fit on the screen.
My phone is pretty tall, but the same issue also occurs when the phone is in landscape view or the app is used in split-screen.

Expected behavior

The buttons at the bottom to cancel or add remain visible.

Actual behavior

The buttons are not visible

Device information

• Firefox version: Nightly 128.0a1
• Android device model: Pixel 6
• Android OS version: 14

Comment 1

[Juliana Gaibler [:juliana]]

Attachment: demo-extension.zip

Here is an unsigned test extension that asks for a lot of permissions :)

Comment 2

[Rebeca Tudor]

Attachment: Bug 1901993 - Make the Addon request permissions dialog scrollable

When the list of permissions was too long, the action buttons weren't visible.
The solutions was to make the dialog scrollable.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/37dab0d4183d
Make the Addon request permissions dialog scrollable r=android-reviewers,amejiamarmol

Comment 4

[Rebeca Tudor]

Attachment: Bug 1901993 - Change into NestedScrollView for addon request permissions dialog

Changed from ScrollView to NestedScrollView.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2345408679aa
Change into NestedScrollView for addon request permissions dialog r=android-reviewers,amejiamarmol

Comment 6

[tszentpeteri]

https://hg.mozilla.org/mozilla-central/rev/37dab0d4183d

Comment 7

[Aron Cseh]

https://hg.mozilla.org/mozilla-central/rev/2345408679aa

Comment 8

[Lorand Janos]

Managed to reproduce this issue on the latest Beta build (128.0b7) using the following steps:

1. set "xpinstall.signatuers.required" to "false" in about:config
2. create "xpinstall.signatuers.dev-root" and set it to "true" in about:config
3. access https://addons.allizom.org/en-US/firefox/addon/all-of-the-permissions/ (desktop Firefox add-on but it doesn't matter)
4. Long tap on "Add to Firefox" to bring up the context menu and select "Download link". The .xpi should be downloaded on the mobile device.
5. Access the browser settings and scroll to the bottom. Tap on "About Firefox Nightly".
6. Tap 7 times on the Nightly logo to enable the secret menu
7. Go back to the previous page (Settings page). An "Install add-on from file" option should now be available under "Advanced"
8. Tap on "Install add-on from file" and navigate to the location where the .xpi from Step (4) was downloaded. And tap on the .xpi. This should start the install process
9. Permissions pop-up is displayed

Verified as fixed on the latest Nightly build (129.0a1 from 2024-06-26) using the same steps. The permissions list is scrollable, the buttons are displayed at the bottom.

Device used: Samsung Galaxy S23 Ultra (Android 14).

Marking the ticket as verified on 129.

Comment 9

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:rebecatudor273, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.