1902001 - [traceback] ValueError invalid ipv6 url in /sources/highlight/

Status: RESOLVED FIXED

(Socorro :: Webapp, defect, P3)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

Sentry: https://mozilla.sentry.io/issues/5438091896/events/10770608919546f681016d46babcf1cc/

Traceback:

ValueError: Invalid IPv6 URL
  File "django/core/handlers/exception.py", line 55, in inner
    response = get_response(request)
  File "django/core/handlers/base.py", line 197, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "crashstats/crashstats/decorators.py", line 149, in inner
    response = view(request, *args, **kwargs)
  File "crashstats/sources/views.py", line 56, in highlight_url
    parsed = urlsplit(url)
  File "urllib/parse.py", line 497, in urlsplit
    raise ValueError("Invalid IPv6 URL")

The url querystring param is:

https://crash-stats.allizom.org[@a.xxx.org/?

This happened in the stage environment and is probably from fuzzing. We should add handling for this case and return an HTTP 400 because the it's a bad request or something like that.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this. It's from fuzzing, but it's probably an easy fix.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: [mozilla-services/socorro] bug-1902001: fix source highlight with bad urls (#6783)

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR [mozilla-services/socorro]: bug-1902001: fix source highlight with bad urls (#6783) in 9384ecc.

Comment 4

[Daniel Thorn [:relud]]

This was deployed in v2024.11.04.

NIing :willkg as the assignee in case there's anything that needs verifying in prod (and to update this ticket's status).

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Looks good.