19021 - HPUX 10.20 doesn't build/run - error unresolved static_iid

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Jim Dunn]

On 10.20 builds using aCC we found a problem with an unresolved
symbol 'static_iid' in libxpcom.sl.  Unfortunately this is not
a 'normal' symbol and doens't show up in any preprocessed file.

Using the linker option -Wl,-ystatic_iid, I was able to trace this
to xpcom/proxy/src and a GetIID function.

Comment 1

[Jim Dunn]

turns out it was something weird with the proxy's way of setting
IID, the following 2 changes fixed it.

Index: nsProxyEvent.h
===================================================================
RCS file: /cvsroot/mozilla/xpcom/proxy/public/nsProxyEvent.h,v
retrieving revision 1.19
retrieving revision 1.21
diff -r1.19 -r1.21
79c79,81
<         NS_DEFINE_STATIC_IID_ACCESSOR(nsCOMTypeInfo<nsISupports>::GetIID())
---
>     NS_DEFINE_STATIC_IID_ACCESSOR(NS_ISUPPORTS_IID)
>       // wierd, but it shouldn't break.  Need to discuss this with dougt
>


Index: nsProxyEventPrivate.h
===================================================================
RCS file: /cvsroot/mozilla/xpcom/proxy/src/nsProxyEventPrivate.h,v
retrieving revision 1.23
retrieving revision 1.24
diff -r1.23 -r1.24
67c67
<     static const nsIID& GetIID() {static nsIID iid = kProxyEventClassIID;
return iid;}
---
>     static const nsIID& GetIID() {static nsIID iid = NS_PROXYEVENT_CLASS_IID;
return iid;}
99c99
<     static const nsIID& GetIID() {static nsIID iid = kProxyEventObjectIID;
return iid;}
---
>     static const nsIID& GetIID() {static nsIID iid = NS_PROXYEVENT_OBJECT_IID;
return iid;}

Comment 2

[leger]

Resetting QA contact for build team to verify

Comment 3

[Jim Dunn]

jon, before we got an error building proxytests (the 10.20 salerno
tinderbox was always red.  it now now green, hence verified)

Comment 4

[Jon Granrose]

marking verified.