Closed Bug 1902326 Opened 2 years ago Closed 2 years ago

Perma devtools/client/netmonitor/<test> | Test timed out when Gecko 129 merges to beta on 2024-07-08

Categories

(DevTools :: Netmonitor, defect, P2)

Desktop
Windows
defect

Tracking

(firefox-esr115 unaffected, firefox127 unaffected, firefox128 unaffected, firefox129+ verified)

VERIFIED FIXED
Tracking Status
firefox-esr115 --- unaffected
firefox127 --- unaffected
firefox128 --- unaffected
firefox129 + verified

People

(Reporter: abutkovits, Assigned: jdescottes)

References

Details

(Keywords: regression)

Attachments

(1 file)

Thanks for the ping!

Just curious, are we are sure that Bug 1756770 regressed this or is this just a supposition at this point?

Flags: needinfo?(abutkovits)

This did not start with bug 1756770, the dt4 task already failed on Tuesday for the central-as-beta simulations.

Flags: needinfo?(abutkovits)

Regression range (successful run on Sunday, no run on Monday, failed on Tuesday)

Indeed it's already failing on https://treeherder.mozilla.org/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunning%2Cpending%2Crunnable&revision=99ed39877ba3ca5997b4dc0e0da89273e80d91c7&searchStr=dt&selectedTaskRun=cd8kyyT9TC293QCjzawrrQ.0 where my change did not land (It's in the regression range, but the backout as well).

I'm going to remove bug 1756770 as the regressing bug for now. The failures only seem to occur on windows at the moment.

Flags: needinfo?(jdescottes)
OS: Unspecified → Windows
No longer regressed by: 1756770
Hardware: Unspecified → Desktop

Another beta sim based on the change which landed in bug 1823907 succeeded. Only bug 1824726 and bug 1882089 landed between that and the first failure.

Alexandre, could investigate if this bug is a regression from bug 1824726?

Flags: needinfo?(poirot.alex)
Flags: needinfo?(poirot.alex)
See Also: → 1902857
Severity: -- → S3
Priority: -- → P2

Nicolas, can you try running some of those tests on windows with a beta simulation?

Flags: needinfo?(nchevobbe)

(In reply to Julian Descottes [:jdescottes] from comment #8)

Nicolas, can you try running some of those tests on windows with a beta simulation?

I tried a bit but I don't reproduce :/

Flags: needinfo?(nchevobbe)

Try push with some nightly-only necko prefs to false on Nightly helps to reproduce the issue: https://treeherder.mozilla.org/jobs?repo=try&revision=5cf518f4bfbf9d57b12c5b6f7ab3eed10e665af7

Edit: Does not seem to trigger the issue, unfortunately.

If we don't have time to find the root cause of the issue, we will need to skip the failing tests on windows+beta for now. Let's see if it's only about the 2 which failed so far: https://treeherder.mozilla.org/jobs?repo=try&revision=15289293e28c6e8cfc95f026af44655444aabd46

Interesting thing to note is that the throttling of server side resources normally doesn't impact the network events because they are emitted by the Watcher actor, not the target actor, and the watcher actor is not throttled yet.

So in practice the main difference for netmonitor tests with bug 1824726 is that we lost the client side throttling for resources.
But adding some logs, I can't even see the updates for the missing event timings.

I think for now we should skip the frequently failing tests on beta + win, and investigate in a followup.

Keywords: leave-open

After introducing resource throttling on the server side, we removed client side throttling which seems to frequently fail netmonitor tests on windows + beta

Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
See Also: → 1905540
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/882e75547c1f [devtools] Skip netmonitor tests frequently failing on windows + beta 129 r=ochameau,devtools-reviewers,nchevobbe

Verified and resolved fixed as seen in today's central as beta sim

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: