190239 - optimize AfterEditInner()

Status: RESOLVED INACTIVE

(Core :: DOM: Editor, enhancement, P3)

Description

[leon.zhang]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.0.1) Gecko/20020823 Netscape/7.0

To improve perf of compser, optimizing AfterEditInner will be helpful to that
target.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[leon.zhang]

1) nsHTMLEditRules::AfterEditInner() consumed 7.11%  of the whole app.
  --> nsHTMLEditRules::RemoveEmptyNodes (38.60% of caller)(2.74% of whole app)
  --> nsHTMLEditRules::PromoteRange (16.36% of caller)(1.18% of whole app)
  --> nsHTMLEditRules::AdjustSpecialBreaks (10.96% of caller)(0.78 of whole app)
  --> nsHTMLEditRules::AdjustSlection (10.61% of caller)(0.75 of whole app)
  --> nsHTMLEditRules::ConfirmSelectionInBody (7.96% of caller)(1.12 of whole app)
 
2) nsHTMLEditRules::RemoveEmptyNodes (38.60% of caller)(2.74% of whole app)
   --> nsTextEditUtils::NodeIsType(43.27 of caller) (2.64% of whole app)
   --> nsContentIterator::Init() (16.69% of caller) (0.92 of the root)

3) nsHTMLEditRules::PromoteRange (16.36% of caller)(1.18% of whole app)
   --> nsHTMLEditRules::GetPromotedPoint(68.80 of the caller) (0.81 of whole app)

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Now, it's renamed to HTMLEditor::OnEndHandlingTopLevelEditSubActionInternal() and various methods called by it are renamed and optimized (and being optimized). Please file new bugs for each if you still see performance issues.