1902549 - Right-clicking on an unselected message causes it to be selected, in a synthetic view

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Geoff Lankow (:darktrojan)]

Because synthetic views aren't real, saving the selection does nothing, then when the context menu closes and the selection restored nothing happens and the temporary selection (for the context menu) becomes permanent.

Fortunately because synthetic views live in their own tab we can hack the selection saving mechanism to fix this.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1902549 - Fix saving and restoring the selection of a synthetic view. r=#thunderbird-reviewers

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1902549 - When saving the selection, use message URIs instead of keys. r=#thunderbird-reviewers

This is somehow just as fast, if we ignore a bunch of notifications about the data changing while
restoring the selection. FindIndexOfMsgHdr behaves very differently to FindIndexFromKey which
causes the notifications.

Comment 3

[Alessandro Castellani [:aleca]]

Is this something you think should go in 128? If so please add the needed tracking flag.
Also is this change "safe" at this stage so close to ESR? Do you think there might be some unknown regressions due to these changes?
As you probably guessed, I'm being annoying and paranoid.

Comment 4

[Geoff Lankow (:darktrojan)]

The first patch is pretty safe. The second is a bit more risky but with a few weeks of beta scrutiny (especially at this time of year) it should be okay. I was about to upgrade a test for it, but first I need to repair the test.

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Attachment: WIP: Bug 1902549 - POC: When saving the selection, use `nsIMsgHdr`s instead of keys.

JFYI: Saving the message headers directly seems to work as well and may be a little less complicated. Apparently this takes just as much time and memory as saving message URIs, but doesn't expand previously selected threads when restoring. (I wrote most of this some time ago but had hoped that the new global message db would make this unnecessary.)

Comment 6

[Hartmut Welpmann [:welpy-cw]]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #5)

Apparently this takes just as much time and memory as saving message URIs, but doesn't expand previously selected threads when restoring.

Actually the expansion of threads has nothing to do with URIs vs. headers, there was some fiddling needed to get this (apparently) right ...

Comment 7

[Geoff Lankow (:darktrojan)]

I used keys (and now URIs) because I don't want to keep references to objects. What's in the Map could remain there for the rest of the session, and if it's one or more header objects, that prevents a bunch of stuff from being garbage collected. (Like a memory leak, but on purpose.) Knowing our code they're probably not collected anyway, but there's no need to make it worse.

Comment 8

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1902549 - Add cross-folder virtual folders to browser_mailContext.js. r=#thunderbird-reviewers

Comment 9

[Geoff Lankow (:darktrojan)]

Let's ship the first patch and I'll move the others to a different bug.

Comment 10

[Phabricator Automation]

Comment on attachment 9407442 [details]
Bug 1902549 - When saving the selection, use message URIs instead of keys. r=#thunderbird-reviewers

Revision D213727 was moved to bug 1903910. Setting attachment 9407442 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9407805 [details]
Bug 1902549 - Add cross-folder virtual folders to browser_mailContext.js. r=#thunderbird-reviewers

Revision D213916 was moved to bug 1903910. Setting attachment 9407805 [details] to obsolete.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/031b2780f9e0
Fix saving and restoring the selection of a synthetic view. r=freaktechnik

Comment 13

[Geoff Lankow (:darktrojan)]

Comment on attachment 9407416 [details]
Bug 1902549 - Fix saving and restoring the selection of a synthetic view. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): supernova
User impact if declined: papercut, selection isn't restored properly after a right-click in rare circumstances
Testing completed (on c-c, etc.): on c-c 3 days
Risk to taking this patch (and alternatives if risky): low

Comment 14

[Corey Bryant]

Comment on attachment 9407416 [details]
Bug 1902549 - Fix saving and restoring the selection of a synthetic view. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 15

[Rob Lemley [:rjl]]

Thunderbird 128.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/8d8a3ba6b67a