1902597 - Undelete message does not work in unified folders (cross-folder views)

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Saulius Gurklys]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:129.0) Gecko/20100101 Firefox/129.0

Steps to reproduce:

1. Create a new "Search Folder" (by some search filters) on IMAP box
2. Select newly created "Search Folder" and select a message from the list
3. Delete selected message (by pressing Del or from context menu) - message is marked as deleted
4. Try to undelete it (by pressing Del or from context menu) - message stays deleted

Message can be undeleted by selecting it in real IMAP folder and pressing Del (or from Context menu)

Actual results:

Message stays deleted.

Expected results:

Message should be not deleted.

Comment 1

[Magnus Melin [:mkmelin]]

That works for me.

Comment 2

[Saulius Gurklys]

I have two linux machines with TB 128b1 and very similar setup of mailboxes and "search" folders.

And undelete only work on one "search" folder, on one of the machines.
On another machine, on "search" folder with the same settings, undelete does not work and it does not work on any other "seach" folder of both machines.

Comment 3

[Ramona Gavrilescu]

Hello Wayne,

We have tried but weren’t able to reproduce this issue, we tested with TB 128.0b1(20240611161651) on Ubuntu 22 and Ubuntu 24 using the same steps as above.

Comment 4

[Saulius Gurklys]

I tried to crate a couple new search folders, and for them undelete is working.
It seems that undelete is not working for old search folders only.

Comment 5

[Saulius Gurklys]

I did some more testing.
The undelete is not working when more than one IMAP folder is used for "Search" folder.
This affects new and old "search" folders.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Reproduced with ESR 115 and Daily.

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1902597 - Fix message deletion in cross-folder search views. r=#thunderbird-reviewers

Comment 8

[Wayne Mery (:wsmwk)]

This WFM with 115.13.0 with unified inbox.

Does a Unified folder behave differently?

Comment 9

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #8)

This WFM with 115.13.0 with unified inbox.

Does a Unified folder behave differently?

I just tested this with that version. If "Just mark it as deleted" is chosen in one of the IMAP accounts, deleting a message from that account in the unified inbox marks it as deleted, while undeleting it (pressing [Del] again) doesn't work, the message remains struck through. Simultaneously deleting messages from multiple accounts with different IMAP deletion models can have even worse effects, which the patch also addresses.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/27e24e99bc18
Fix message deletion in cross-folder search views. r=mkmelin