Closed Bug 1902608 Opened 11 months ago Closed 3 months ago

Intermittent warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module

Categories

(Firefox Build System :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED INCOMPLETE

People

(Reporter: intermittent-bug-filer, Unassigned)

Details

(Keywords: intermittent-failure)

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=462327866&repo=mozilla-beta
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NSy_UYdrQVKGac7Ptr4dgw/runs/0/artifacts/public/logs/live_backing.log


[task 2024-06-14T06:00:58.248Z] 06:00:58     INFO -  gmake[4]: Entering directory '/builds/worker/workspace/obj-build/mobile/android/installer'
[task 2024-06-14T06:00:58.249Z] 06:00:58     INFO -  NO_PKG_FILES="core bsdecho js js-config jscpucfg nsinstall viewer TestGtkEmbed elf-dynstr-gc mangle* maptsv* mfc* msdump* msmap* nm2tsv* nsinstall* res/samples res/throbber shlibsign* certutil* pk12util* BadCertAndPinningServer* DelegatedCredentialsServer* EncryptedClientHelloServer* FaultyServer* OCSPStaplingServer* SanctionsTestServer* GenerateOCSPResponse* chrome/chrome.rdf chrome/app-chrome.manifest chrome/overlayinfo components/compreg.dat components/xpti.dat content_unit_tests necko_unit_tests *.dSYM " \
[task 2024-06-14T06:00:58.252Z] 06:00:58     INFO -  /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/build/bin/python /builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.py -DPKG_LOCALE_MANIFEST=/builds/worker/workspace/obj-build/mobile/android/installer/locale-manifest.in -DMOZ_APP_NAME=fennec -DPREF_DIR=defaults/pref -DJAREXT= -DMOZ_CHILD_PROCESS_NAME=libplugin-container.so -DANDROID_CPU_ARCH=armeabi-v7a  -DMOZ_ANDROID_EXCLUDE_FONTS=1 -DMOZ_ANDROID_FAT_AAR_ARCHITECTURES=1 -DDLL_PREFIX=lib -DDLL_SUFFIX=.so -DBIN_SUFFIX= -DDIR_MACOS= -DDIR_RESOURCES= -DMOZ_FOLD_LIBS=1 -DBINPATH=bin -DENABLE_WEBDRIVER=1 -DACCESSIBILITY=1 -DANDROID=1 -DBROWSER_CHROME_URL=chrome://geckoview/content/geckoview.xhtml -DBROWSER_CHROME_URL_QUOTED='"chrome://geckoview/content/geckoview.xhtml"' -DBUILD_ARM_NEON=1 -DBUILD_CTYPES=1 -DCROSS_COMPILE=1 -DEARLY_BETA_OR_EARLIER=1 -DEDITLINE=1 -DENABLE_SHARED_MEMORY=1 -DENABLE_SYSTEM_EXTENSION_DIRS=1 -DENABLE_TESTS=1 -DENABLE_WASM_GC=1 -DENABLE_WASM_JS_STRING_BUILTINS=1 -DENABLE_WASM_MULTI_MEMORY=1 -DENABLE_WASM_TAIL_CALLS=1 -DENABLE_WEBDRIVER=1 -DFORCE_PR_LOG=1 -DGTEST_HAS_CLONE=0 -DGTEST_HAS_RTTI=0 -DGTEST_OS_LINUX_ANDROID=1 -DGTEST_USE_OWN_TR1_TUPLE=1 -DHAVE_ALLOCA_H=1 -DHAVE_ARC4RANDOM=1 -DHAVE_ARC4RANDOM_BUF=1 -DHAVE_ARM_NEON=1 -DHAVE_ARM_SIMD=1 -DHAVE_BYTESWAP_H=1 -DHAVE_CLOCK_MONOTONIC=1 -DHAVE_DLADDR=1 -DHAVE_DLFCN_H=1 -DHAVE_EVENTFD=1 -DHAVE_FTS_H=1 -DHAVE_FT_BITMAP_SIZE_Y_PPEM=1 -DHAVE_FT_GLYPHSLOT_EMBOLDEN=1 -DHAVE_FT_LOAD_SFNT_TABLE=1 -DHAVE_GETC_UNLOCKED=1 -DHAVE_GETOPT_H=1 -DHAVE_GETPAGESIZE=1 -DHAVE_GETTID=1 -DHAVE_GMTIME_R=1 -DHAVE_INTTYPES_H=1 -DHAVE_LINUX_IF_ADDR_H=1 -DHAVE_LINUX_JOYSTICK_H=1 -DHAVE_LINUX_PERF_EVENT_H=1 -DHAVE_LINUX_QUOTA_H=1 -DHAVE_LINUX_RTNETLINK_H=1 -DHAVE_LOCALECONV=1 -DHAVE_LOCALTIME_R=1 -DHAVE_LSTAT64=1 -DHAVE_MALLINFO=1 -DHAVE_MALLOC_H=1 -DHAVE_MALLOC_USABLE_SIZE=1 -DHAVE_MEMALIGN=1 -DHAVE_NETINET_IN_H=1 -DHAVE_NL_TYPES_H=1 -DHAVE_POSIX_FADVISE=1 -DHAVE_POSIX_FALLOCATE=1 -DHAVE_POSIX_MEMALIGN=1 -DHAVE_PTHREAD_COND_TIMEDWAIT_MONOTONIC=1 -DHAVE_PTHREAD_H=1 -DHAVE_SETPRIORITY=1 -DHAVE_STAT64=1 -DHAVE_STATFS=1 -DHAVE_STATFS64=1 -DHAVE_STATVFS=1 -DHAVE_STATVFS64=1 -DHAVE_STDINT_H=1 -DHAVE_STRERROR=1 -DHAVE_STRNDUP=1 -DHAVE_SYSCALL=1 -DHAVE_SYS_MOUNT_H=1 -DHAVE_SYS_QUEUE_H=1 -DHAVE_SYS_STATFS_H=1 -DHAVE_SYS_STATVFS_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_VFS_H=1 -DHAVE_TM_ZONE_TM_GMTOFF=1 -DHAVE_TRUNCATE64=1 -DHAVE_UNISTD_H=1 -DHAVE_UNWIND_H=1 -DHAVE_VISIBILITY_ATTRIBUTE=1 -DHAVE_VISIBILITY_HIDDEN_ATTRIBUTE=1 -DHAVE__UNWIND_BACKTRACE=1 -DJSON_USE_EXCEPTION=0 -DJS_CODEGEN_ARM=1 -DJS_DEFAULT_JITREPORT_GRANULARITY=3 -DJS_HAS_CTYPES=1 -DJS_HAS_INTL_API=1 -DJS_NUNBOX32=1 -DMALLOC_H='<malloc.h>' -DMALLOC_USABLE_SIZE_CONST_PTR=const -DMOZILLA_OFFICIAL=1 -DMOZILLA_UAVERSION='"128.0"' -DMOZILLA_VERSION='"128.0"' -DMOZILLA_VERSION_U=128.0 -DMOZJS_MAJOR_VERSION=128 -DMOZJS_MINOR_VERSION=0 -DMOZ_AARCH64_JSCVT=0 -DMOZ_ANDROID_CONTENT_SERVICE_COUNT=40 -DMOZ_APP_UA_NAME='"Firefox"' -DMOZ_APP_UA_VERSION='"128.0"' -DMOZ_AUTH_EXTENSION=1 -DMOZ_AV1=1 -DMOZ_BACKGROUNDTASKS=1 -DMOZ_BUILD_APP=mobile/android -DMOZ_CLANG_PLUGIN=1 -DMOZ_CRASHREPORTER=1 -DMOZ_DATA_REPORTING=1 -DMOZ_DIAGNOSTIC_ASSERT_ENABLED=1 -DMOZ_DLL_PREFIX='"lib"' -DMOZ_DLL_SUFFIX='".so"' -DMOZ_DOM_STREAMS=1 -DMOZ_FFVPX_AUDIOONLY=1 -DMOZ_GECKOVIEW_HISTORY=1 -DMOZ_GECKO_PROFILER=1 -DMOZ_GECKO_PROFILER_PARSE_ELF=1 -DMOZ_GFX_OPTIMIZE_MOBILE=1 -DMOZ_GLEAN_ANDROID=1 -DMOZ_ICU4X=1 -DMOZ_IGNORE_PAINT_WILL_RESAMPLE=1 -DMOZ_INSTRUMENT_EVENT_LOOP=1 -DMOZ_LINKER=1 -DMOZ_LOGGING=1 -DMOZ_MACBUNDLE_ID=org.mozilla.firefoxnightly -DMOZ_MEMORY=1 -DMOZ_NO_SMART_CARDS=1 -DMOZ_OXIDIZED_BREAKPAD=1 -DMOZ_PDF_PRINTING=1 -DMOZ_PEERCONNECTION=1 -DMOZ_PROFILER_MEMORY=1 -DMOZ_PROXY_DIRECT_FAILOVER=1 -DMOZ_RAW=1 -DMOZ_REAL_TIME_TRACING=1 -DMOZ_REPLACE_MALLOC=1 -DMOZ_RUST_SIMD=1 -DMOZ_SAMPLE_TYPE_FLOAT32=1 -DMOZ_SCTP=1 -DMOZ_SERVICES_HEALTHREPORT=1 -DMOZ_SRTP=1 -DMOZ_STATIC_JS=1 -DMOZ_TELEMETRY_REPORTING=1 -DMOZ_THUMB2=1 -DMOZ_TREE_FREETYPE=1 -DMOZ_TREE_PIXMAN=1 -DMOZ_UPDATE_CHANNEL=beta -DMOZ_USER_DIR='".mozilla"' -DMOZ_USING_WASM_SANDBOXING=1 -DMOZ_VERIFY_MAR_SIGNATURE=1 -DMOZ_VORBIS=1 -DMOZ_WASM_SANDBOXING_EXPAT=1 -DMOZ_WASM_SANDBOXING_GRAPHITE=1 -DMOZ_WASM_SANDBOXING_HUNSPELL=1 -DMOZ_WASM_SANDBOXING_OGG=1 -DMOZ_WASM_SANDBOXING_SOUNDTOUCH=1 -DMOZ_WASM_SANDBOXING_WOFF2=1 -DMOZ_WEBRTC=1 -DMOZ_WEBRTC_ASSERT_ALWAYS=1 -DMOZ_WEBRTC_SIGNALING=1 -DMOZ_WEBSPEECH=1 -DMOZ_WEBSPEECH_TEST_BACKEND=1 -DMOZ_WIDGET_ANDROID=1 -DNO_NSPR_10_SUPPORT=1 -DNS_PRINTING=1 -DNS_PRINT_PREVIEW=1 -DRELEASE_OR_BETA=1 -DSTATIC_JS_API=1 -DSTDC_HEADERS=1 -DTARGET_XPCOM_ABI='"arm-eabi-gcc3"' -DU_STATIC_IMPLEMENTATION=1 -DU_USING_ICU_NAMESPACE=0 -DWASM_HAS_HEAPREG=1 -DXP_LINUX=1 -DXP_UNIX=1 -DZLIB_IN_MOZGLUE=1 -D_LIBCPP_ALWAYS_INLINE='' -D_LIBCPP_HIDE_FROM_ABI='__attribute__((__exclude_from_explicit_instantiation__))' -D_LIBCPP_INLINE_VISIBILITY='' -DAB_CD=en-US \
[task 2024-06-14T06:00:58.252Z] 06:00:58     INFO -  	--format omni \
[task 2024-06-14T06:00:58.252Z] 06:00:58     INFO -  	--removals /builds/worker/checkouts/gecko/mobile/android/installer/removed-files.in \
[task 2024-06-14T06:00:58.252Z] 06:00:58     INFO -  	--ignore-errors \
[task 2024-06-14T06:00:58.252Z] 06:00:58     INFO -  	 \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  	--minify \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  	--minify-js --js-binary /builds/worker/checkouts/gecko/mobile/android/config/js_wrapper.sh  \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  	 \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  	 \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  	/builds/worker/checkouts/gecko/mobile/android/installer/package-manifest.in '../../../dist' '../../../dist'/geckoview \
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:23: Missing file(s): bin/dictionaries/*
[task 2024-06-14T06:00:58.253Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:83: Missing file(s): bin/package-name.txt
[task 2024-06-14T06:00:58.254Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:92: Missing file(s): bin/components/components.manifest
[task 2024-06-14T06:00:58.254Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:95: Missing file(s): bin/components/toolkitsearch.manifest
[task 2024-06-14T06:00:58.254Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:121: Missing file(s): bin/features/*
[task 2024-06-14T06:00:58.254Z] 06:00:58     INFO -  warning: $SRCDIR/mobile/android/installer/package-manifest.in:136: Missing file(s): bin/defaults/pref/channel-prefs.js
[task 2024-06-14T06:00:58.254Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AboutCertViewerChild.sys.mjs:
[task 2024-06-14T06:00:58.254Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AboutCertViewerParent.sys.mjs:
[task 2024-06-14T06:00:58.255Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: export declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.255Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AboutPagesUtils.sys.mjs:
[task 2024-06-14T06:00:58.256Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: export declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.256Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AbuseReporter.sys.mjs:
[task 2024-06-14T06:00:58.257Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.257Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.257Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.257Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.257Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/ActorManagerParent.sys.mjs:
[task 2024-06-14T06:00:58.257Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.257Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.258Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.258Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.258Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AddonManager.sys.mjs:
[task 2024-06-14T06:00:58.258Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.258Z] 06:00:58     INFO -  warning: Stack:
[task 2024-06-14T06:00:58.259Z] 06:00:58     INFO -  warning:   ast@/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:25
[task 2024-06-14T06:00:58.259Z] 06:00:58     INFO -  warning:   @/builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:28:12
[task 2024-06-14T06:00:58.259Z] 06:00:58     INFO -  warning: JS minification verification failed for ../../../dist/bin/modules/AddonSearchEngine.sys.mjs:
[task 2024-06-14T06:00:58.259Z] 06:00:58    ERROR -  warning: /builds/worker/checkouts/gecko/toolkit/mozapps/installer/js-compare-ast.js:21:24 SyntaxError: import declarations may only appear at top level of a module
[task 2024-06-14T06:00:58.259Z] 06:00:58     INFO -  warning: Stack:
<...>

This warnings can also be found on green jobs as it can be seen here but this time they appeared as failures in treeherder.

The real failures were further down in those logs, but regardless, we should probably fix these anyway to clean up the logspam.

Severity: S4 → --
Component: Installer → General
Priority: P5 → --
Product: Firefox → GeckoView
Product: GeckoView → Firefox Build System

(In reply to Ryan VanderMeulen [:RyanVM][PTO June 24-28] from comment #2)

The real failures were further down in those logs, but regardless, we should probably fix these anyway to clean up the logspam.

For the record, the real failures were the same as in bug 1901938: abort: destination exists but no .hg directory

That bug has a relevant comment:
https://bugzilla.mozilla.org/show_bug.cgi?id=1901938#c10
The minifier is jsmin and that project hasn't been updated in years. It probably doesn't support the ES module syntax anyway then.

What's a state-of-the-art js minifier that we could use to replace jsmin?

Flags: needinfo?(standard8)

Here's a couple we've heard of, but we don't really have any experience as to which might be the best option:

https://github.com/evanw/esbuild
https://github.com/terser/terser

Flags: needinfo?(standard8)
Severity: -- → S3
Priority: -- → P3
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 10 months ago4 months ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Status: REOPENED → RESOLVED
Closed: 4 months ago3 months ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.