1902683 - Screenshot mode is not exited when Enter key is pressed on the focused Cancel button

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Simona Badau, Desktop QA]

Found in

• Firefox 128.0b2

Affected versions

• Firefox 127
• Firefox 128 Beta
• Nightly 129.0a1

Tested platforms

• Affected platforms: Ubuntu 22.04, macOS 13, Windows 10

Steps to reproduce

1. Navigate to any website and enable Screenshots by pressing Ctrl/Cmd+Shift+S keys.
2. Place the mouse somewhere on the Screenshot overlay.
3. Use the Tab key to navigate to the Cancel button.
4. Press the Enter key.

Expected result

• Screenshot mode should be exited when the Enter Key is pressed while the Cancel button is in focus.

Actual result

• Instead of exiting Screenshots mode, a new area is selected.
• This behaviour is not encountered when pressing Space instead of Enter.

Regression range

• The issue is present in all curent versions, not sure if it's a regression. I'll investigate more as soon as possible.

Comment 1

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/805b6d6eda9f
Early return on keydown when screenshots button is focused. r=sfoster

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/805b6d6eda9f

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox128 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Niklas Baumgardner [:niklas]]

Comment on attachment 9407591 [details]
Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster

Beta/Release Uplift Approval Request

• User impact if declined: Using the "Enter" key on a button in screenshots does not work.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Steps to reproduce:

1. Navigate to any website and enable Screenshots by pressing Ctrl/Cmd+Shift+S keys.
2. Use the mouse to hover over an element on the page so the hover element region is visible.
3. Use the Tab key to navigate to the Cancel button.
4. Press the Enter key.

ER:
The screenshots UI will close

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is pretty low risk. It only returns early if a key events happens on a button to prevent the bug from occurring.
• String changes made/needed: No
• Is Android affected?: No

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9407591 [details]
Bug 1902683 - Early return on keydown when screenshots button is focused. r=sfoster

Approved for 128.0b5.

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/66f807d4b330

Comment 8

[Simona Badau, Desktop QA]

Verified as fixed using the latest Nightly 129.0a1 (Build ID: 20240618214224) on Ubuntu 22.04, macOS 13 and Windows 10.

Comment 9

[Simona Badau, Desktop QA]

Verified as fixed using the latest Firefox 128.0b5 on macOS 13, Ubuntu 22.04 and Windows 10.